Not Able to launch about dwarf HOT 9 CLOSED

Checking in 5 minutes :) thanks!

from dwarf.

ok.. i've added a null check here 724c907 that should at least fix the crash but you will face some more i think. Make sure git binary is in your PATH

from dwarf.

Still:

adb: True
dev/emu: True
su: True
root: False

at least 3x True required
Traceback (most recent call last):
File "D:\Tools for Testing\Dwarf\Dwarf\ui\ui_welcome.py", line 67, in run
self.on_finished.emit('Failed to fetch commit list. Try later.')
TypeError: DwarfCommitsThread.on_finished[] signal has 0 argument(s) but 1 provided

from dwarf.

@PinkiePieStyle help here :D

from dwarf.

i guess

line 46 should then be:

    on_finished = pyqtSignal(str)

line 90 should then be:

        self.on_finished.emit('')

@mohittyagi11 can you try replacing those lines and tell me if it goes straight?

from dwarf.

There is nothing connected.
Comment out Line 61, 67, 90

from dwarf.

Hi,

Both suggestion seems to work :)

from dwarf.

I'll commit @PinkiePieStyle way

from dwarf.

I'm closing this with c89094b

thanks for report :)

from dwarf.