Giter VIP home page Giter VIP logo

Comments (5)

carlost avatar carlost commented on May 24, 2024

I am not sure what a clean solution to this might be. We don't need to instrument our rake tasks, so we just monkey patched Rake::Task to remove the RailsPerformance instrumentation. If we needed to instrument rarke I think our solution would have been to:

  • update the #invoke method in rake_ext.rb to check RailsPerformance.enabled before instrumenting a rake call and,
  • default RailsPerformance.enabled to false ... that way rake tasks invoked before the rails env is loaded and before the rails_perrformance initialization file is required will not trigger instrumentation.

from rails_performance.

igorkasyanchuk avatar igorkasyanchuk commented on May 24, 2024

@carlost can you prepare a PR?

from rails_performance.

hmontazeri avatar hmontazeri commented on May 24, 2024

same issue here 😢

In my case CI fails as asset precompile loads the app.

from rails_performance.

haffla avatar haffla commented on May 24, 2024

Didn't I fix that in #30?

@igorkasyanchuk could you create a new release that includes it?

from rails_performance.

igorkasyanchuk avatar igorkasyanchuk commented on May 24, 2024

sorry for a delay,
new version rails_performance-1.0.1.gem just released
thanks!

from rails_performance.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.