Comments (5)
I am not sure what a clean solution to this might be. We don't need to instrument our rake tasks, so we just monkey patched Rake::Task to remove the RailsPerformance instrumentation. If we needed to instrument rarke I think our solution would have been to:
- update the
#invoke
method in rake_ext.rb to checkRailsPerformance.enabled
before instrumenting a rake call and, - default RailsPerformance.enabled to false ... that way rake tasks invoked before the rails env is loaded and before the rails_perrformance initialization file is required will not trigger instrumentation.
from rails_performance.
@carlost can you prepare a PR?
from rails_performance.
same issue here 😢
In my case CI fails as asset precompile loads the app.
from rails_performance.
Didn't I fix that in #30?
@igorkasyanchuk could you create a new release that includes it?
from rails_performance.
sorry for a delay,
new version rails_performance-1.0.1.gem just released
thanks!
from rails_performance.
Related Issues (20)
- Using with redis cluster HOT 5
- Exception when `serve_static_files` is disabled HOT 12
- question: why append RailsPerformance::Extensions to LogSubscriber instead of integrating with Rails notifications directly HOT 1
- undefined method `insert_css_file' for #<ActionView::Base:0x0000000005cc88> HOT 4
- undefined method `default?' for nil:NilClass HOT 3
- No Data...how to debug? HOT 3
- When using Docker, the config always initiated before version created resulting cannot read envar config HOT 8
- Ignore monitoring of some requests HOT 5
- CI suport for Ruby 3.1 / 3.X
- handle case when redis is out of memory - Redis::OutOfMemoryError HOT 1
- undefined method `devise_for' in new version 1.0.5.1 HOT 1
- When there is a lot of requests, "Recent Requests" page stuck while loading on browser HOT 4
- Does not work without ActiveRecord HOT 2
- ERR too many keys to fetch, please use SCAN HOT 1
- Grape requests not showing in 'Requests Analysis' page HOT 2
- How does storage work? HOT 5
- Compatibility with Rails 6 HOT 1
- Cannot skip setting `config.mount_at` when using `mount RailsPerformance::Engine` in routes.rb
- depend on ralties instead of rails HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rails_performance.