Comments (12)
Igosuki
commented on June 14, 2024
1
Thanks a lot, I will add you to contributions.
…On Wed, Jun 22, 2022, 07:30 Henry.Huang ***@***.***> wrote:
- Hi @Igosuki <https://github.com/Igosuki>
- I have done all the APIs fixes and tests.
- #36 <#36>
- You can review the codes. This PR is ready to be merged.
—
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADDFBRGIXTV67IZAIZH4LLVQKQI3ANCNFSM5YLOSCVQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
from binance-rs-async.
Igosuki
commented on June 14, 2024
1
I cleaned up the PR and merged from another branch
from binance-rs-async.
Igosuki
commented on June 14, 2024
Hi @hhstore, thank you for bringing this up, I implemented all the endpoints following the docs but didn't test them individually (lack of time).
Let me know when you are finished and we can do a release.
from binance-rs-async.
hhstore
commented on June 14, 2024
Hi @hhstore, thank you for bringing this up, I implemented all the endpoints following the docs but didn't test them individually (lack of time). Let me know when you are finished and we can do a release.
- OK. I am still developing.
- The fixes that have been submitted are all tested.
- I'll let you know when I finish the main part of the
wallet api.
from binance-rs-async.
Igosuki
commented on June 14, 2024
I'm ok with adding utility methods, just make it clear in doc strings that it does more than calling an endpoint.
from binance-rs-async.
hhstore
commented on June 14, 2024
I'm ok with adding utility methods, just make it clear in doc strings that it does more than calling an endpoint (端点) .
- Ok.
- 2 utility methods, I will update comments + use cases. (unit tests will also be updated)
- I will give more detailed comments on the newly added 2 APIs(deposit/withdraw history API).
- The official
deposit/withdraw historyAPI is very inconvenient to use. - Need me to add an example
return value structureof the new API to the API doc?
from binance-rs-async.
hhstore
commented on June 14, 2024
update:
- https://github.com/Igosuki/binance-rs-async/pull/36/files#diff-4007187965c1fea4fd252a76f5f1007b2ea59f6d86e2f454edee547c5036be24R110
- https://github.com/Igosuki/binance-rs-async/pull/36/files#diff-4db9c4cca2ff80c2ad80cbf7111959e148b31ee24cb354f8620c417047fe7b46R161
- Latest commit, renamed utility methods, improved some annotations and unit tests.
from binance-rs-async.
Igosuki
commented on June 14, 2024
If we are returning a struct, just point to that
…On Sat, Jun 18, 2022, 01:00 Henry.Huang ***@***.***> wrote:
I'm ok with adding utility methods, just make it clear in doc strings that
it does more than calling an endpoint (端点) .
- Ok. I will give more detailed comments on the newly added 2
APIs(deposit/withdraw history API).
- The official deposit/withdraw history API is very inconvenient to
use.
- Need me to add an example return value structure of the new API to
the API doc?
—
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADDFBUVAU7LZET7P65FQG3VPT7SVANCNFSM5YLOSCVQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
from binance-rs-async.
hhstore
commented on June 14, 2024
- Hi @Igosuki
- I have done all the APIs fixes and tests.
- #36
- You can review the codes. This PR is ready to be merged.
from binance-rs-async.
Igosuki
commented on June 14, 2024
@hhstore Are you ok if I change your PR a bit for API consistency purposes ?
from binance-rs-async.
hhstore
commented on June 14, 2024
@hhstore Are you ok if I change your PR a bit for API consistency purposes ?
- No problem, feel free to modify it.
from binance-rs-async.
hhstore
commented on June 14, 2024
that's great.
from binance-rs-async.
Related Issues (20)
- Stop Loss Orders & Take Profit Orders for futures HOT 3
- NOT working - get_exchange_info HOT 1
- Support Universal Transfer HOT 5
- Add cargo crate URL to github repo description HOT 1
- Crates.io description says async-std, when the Tokio is used HOT 4
- To support proxy connection to binance websocket HOT 6
- Margin Account cancel_all_orders on open OCO order yields MarginOCOOrderResult instead of MarginOrderCancellationResult HOT 6
- add PartialEq on OrderStatus and similar types HOT 1
- errors while using the wallet feature? HOT 2
- Is futures websocket stream not implemented? HOT 10
- futures position_information implementation HOT 1
- The GET method internally creates a new `reqwest::Client` each time.
- Configure timeout of the client. HOT 5
- Dependency Dashboard
- Proxy support? HOT 11
- Version 1.3.2 didn't match with the available ones HOT 2
- Signature for this request in not valid HOT 2
- How to solve recvWindow error?
- tokio-tungstenite updating to version 0.20 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from binance-rs-async.