Giter VIP home page Giter VIP logo

Comments (2)

ihabshea avatar ihabshea commented on August 30, 2024

Hello,
Have you tried adding a return function with your cleanup operations like this:
return ( () => { unsubscribe(); });

from reactasynchooks.

platoonic avatar platoonic commented on August 30, 2024

I haven't tried it yet tbh but looking how useEffectAsync is implemented, it doesn't seem to be handling the unmounting phase at all.

export default function useEffectAsync(effect, inputs) {
    useEffect(() => {
        effect();
    }, inputs);
}

Thing is, adding a line like this:

return effect();

Will trigger the same problem of useEffect not supporting a non-functional return type since it's returning a promise object. I think there should be some sort of API that handles passing those cleanup functions, one that's different from how the original useEffect handles it.
This package for example takes cleanup function as a second optional argument in its useAsyncEffect hook:
https://github.com/rauldeheer/use-async-effect

from reactasynchooks.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.