support "complete_request" about ihaskell HOT 4 CLOSED

The json generated out of here https://github.com/aavogt/IHaskell/blob/master/IHaskell/Completion.hs seems like it should have some impact on the notebook, but instead I get nothing coming up there.

from ihaskell.

This is awesome! I'm afraid I can't look into any of the issues until the
weekend, but if you'd like to put together a PR for the complete_request
and other stuff when you feel this is ready I am happy to get it merged
soon. Will also look into the rest of your suggestions / bug reports as
soon as I have a bit of time :)

Thanks for the help!

On Thu, Oct 24, 2013 at 7:44 PM, Adam Vogt [email protected] wrote:

The json generated out of here
https://github.com/aavogt/IHaskell/blob/master/IHaskell/Completion.hsseems like it should have some impact on the notebook, but instead I get
nothing coming up there.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/8#issuecomment-27053045
.

from ihaskell.

Merging it now would fix that crash. Completions should depend on the context (filename, module name, identifier etc.), which will take a lot more code what's currently done in IHaskell.Completion.hs. Maybe ghc-mod could be put to use.

from ihaskell.

I'm closing this for the time being. Currently, completions are found using the names in scope. It'd be nice to have it do something much more intelligent than that, but that is significantly in the future, and would require quite a bit of prior thought and design.

from ihaskell.