Giter VIP home page Giter VIP logo

Comments (4)

oleg-derevenetz avatar oleg-derevenetz commented on July 23, 2024

I'd say that the reason is the same as in #8376 and #8375 - WAV sound effect playback is started with a noticeable delay on this particular PC, which shouldn't be, because WAV playback is very cheap.

from fheroes2.

oleg-derevenetz avatar oleg-derevenetz commented on July 23, 2024

Marking this as an audio-related issue but it's just a guess because I cannot reproduce this on my devices.

from fheroes2.

oleg-derevenetz avatar oleg-derevenetz commented on July 23, 2024

I would say that the problem here and in other similar issues (#8375, #8376) is that WAV sound is played at the same moment that the MIDI music starts (and the MIDI music is a heavy thing), and until the MIDI music starts, it's impossible to play anything else, because SDL_mixer functions themselves are not safe for simultaneous use from multiple threads (at least it seems so after a cursory acquaintance with their insides).

This problem is observed with MIDI music only (not with external music, because external MP3/FLAC/OGG music is a relatively light thing in comparison with MIDI). Playback of horse steps is performed in background thread, therefore, their playback is just delayed a bit - that's why their playback continues a little longer after the hero stops, while playback of musical effects for map objects is performed in the main thread, and this can lead to animation delays when the corresponding object located on the border of two terrains with different music is visited. The same applies to the playback of musical effects for units at the beginning of the battle when the background battle MIDI music starts.

from fheroes2.

LeHerosInconnu avatar LeHerosInconnu commented on July 23, 2024

Hello @Branikolog,

Hi, @LeHerosInconnu Are you using MIDI? I believe this issue is valid only for MIDI sound, while for external music I cannot reproduce this problem.

Yes, MIDI is used when the problem is detected. I did a test with .ogg files in the MUSIC folder and "Music Type" set to "External" and the problem is no longer present. There must have been a change in MIDI management at some point.

Originally posted by @LeHerosInconnu in #8375 (comment)

from fheroes2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.