Comments (1)
I recently worked on this in my fork. There is another case which should be considered: when the user drags & drops a video into the existing window. I think it seems more natural to leave the sidebar open in that case. But in the other cases, I agree it should be closed.
My code has diverged too much to submit a PR from it, but I think you may be able to just add code to MainWindowController.windowWillClose()
which sets the sidebars to their default closed state. It might be tempting to add logic in windowWillOpen()
and/or windowDidOpen()
, but despite their names, they can be called if the window was already open (or with windowWillOpen
, will be called only in some very specific cases like first load, minimized, or hidden).
from iina.
Related Issues (20)
- 有些影片播放发绿,需要手动调整色调,能否自动优化调整 HOT 4
- `iina-cli` doesn't work when stdin is /dev/null HOT 2
- Hebrew locale not work in Sparkle HOT 3
- Separate "Resume last playback position" for video and audio files HOT 1
- Numbers on the sliders in QuickSettingView not centered HOT 1
- The content in Log Window is right to left in Hebrew HOT 3
- The right time label shows xx:xx- instead of -xx:xx when in `.remaining` mode in Hebrew HOT 2
- m3u playlists exported from Apple Music cannot be read HOT 1
- Automatic subtitle translation
- RTL: Incorrect arrow icon direction in browser extensions reference HOT 6
- Text clipping in the audio delay slider
- Enable Screensaver While Playing Audio Files in IINA Media Player HOT 4
- Incorrect text alignment in the battery icon of the OSD in RTL HOT 1
- Some feature requests HOT 2
- Can't change color for built-in subtitles HOT 4
- How to use localized IINA HOT 4
- "Check for update" does not detect new version HOT 1
- The compilation date in the debug build in RTL languages seems not rendered correctly HOT 5
- Unauthorized link to crowdin contributors in IINA's About window
- If a NAS share cannot be reached, iina fails to start HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from iina.