Giter VIP home page Giter VIP logo

Comments (7)

low-batt avatar low-batt commented on June 15, 2024 1

It is looking like our next release will be focused on fixing regressions with a feature release to follow. To get this in now for the next release I wanted to minimize the changes required. That is why I wanted to avoid trying to expand the size of this UI. I do agree that more precision is desirable.

The current code for downloading subtitles is considered legacy code. The plan is to replace the existing code with a plugin implementation. Hopefully that work will include enhancements to the user interface.

On using an icon, I did look around for an icon. I found a lot of them. They were associated with online gaming. I didn't find anything I thought people would recognize as frames per second. Are you aware of something?

For this change I would not have used an icon as that would require a lot of changes as the UI is not structured for that. What looks like icons in the UI is actually characters:

⬇︎
DOWNWARDS BLACK ARROW
Unicode: U+2B07 U+FE0E, UTF-8: E2 AC 87 EF B8 8E


BLACK STAR
Unicode: U+2605, UTF-8: E2 98 85

I will check with the other developers to see if they think it is ok to squeeze in a couple more characters.

from iina.

rasitayaz avatar rasitayaz commented on June 15, 2024 1

I think a more compact date & time formatting would save some space for the other items. I doubt anyone will ever want to know the exact seconds of the upload date.

from iina.

low-batt avatar low-batt commented on June 15, 2024

@browser-bug Thanks for entering this issue.

As the spacing is rather tight I rounded the fps up. Do you think that is sufficient or is more precision required?
subtitle-fps

from iina.

browser-bug avatar browser-bug commented on June 15, 2024

@low-batt
Thanks to you for addressing the issue. I guess a round up will do aswell, since the most common values are always 24, 25, 30 or 60 to my knowledge. But still, being more precise doesn't hurt. If the spacing is too tight and there are no other options I guess rounding will do just fine. Maybe an icon on the left?

from iina.

low-batt avatar low-batt commented on June 15, 2024

The fix for this issue has been merged into the IINA develop branch. GitHub automatically closed the linked issue in reaction to the merge. I am reopening this issue until the fix is available in an official release of IINA so that users intending to report this problem can easily locate this existing report. Once the fix for this issue has been included in an official release this issue will be closed.

from iina.

rasitayaz avatar rasitayaz commented on June 15, 2024

also related to this menu, I'd like to bring up #4142. having the subtitle file name multilined or marquee-like would be great.

from iina.

low-batt avatar low-batt commented on June 15, 2024

This was added in IINA 1.3.5.

from iina.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.