Change callback argument of beforePortalReRender hook about ingress-intel-total-conversion HOT 5 CLOSED

I just noticed this issue had been left untouched!

Making that exact change would break existing plugins, yes?

However, adding new fields without changing existing data is fine. So just add in the portal guid?

from ingress-intel-total-conversion.

I was just going to comment on this also. Just looked into it, and yeah I agree with jonatkins. We can add in portalGuid and oldPortalGuid to the callback or something similar.

from ingress-intel-total-conversion.

Oh actually only need portalGuid as they are both the same. Opps.

from ingress-intel-total-conversion.

Yes it would break existing plugins, but there are none which use it in your version yet. The proposed Fix from Fragger also changes the hooks-api. If you decide the api i think its much better to pass the whole portal for more flexibility. Someon might want to access the other aspects too.

from ingress-intel-total-conversion.

adding a new field doesn't break compatibility when it comes to the API - passing a different data structure to an existing field does.

Also, just because we have no plugins using the API, it doesn't mean that others don't. There are many plugins out there, some developed for personal use, some for use within regional communities, and some elsewhere on Github.

@Fragger's change has been accepted and I'm closing this for now. We can always add more new fields later if the need arises for additional data - including one such as "portalv2: ent" if a need for the larger data structure is required.

from ingress-intel-total-conversion.