Comments (5)
I just noticed this issue had been left untouched!
Making that exact change would break existing plugins, yes?
However, adding new fields without changing existing data is fine. So just add in the portal guid?
from ingress-intel-total-conversion.
I was just going to comment on this also. Just looked into it, and yeah I agree with jonatkins. We can add in portalGuid and oldPortalGuid to the callback or something similar.
from ingress-intel-total-conversion.
Oh actually only need portalGuid as they are both the same. Opps.
from ingress-intel-total-conversion.
Yes it would break existing plugins, but there are none which use it in your version yet. The proposed Fix from Fragger also changes the hooks-api. If you decide the api i think its much better to pass the whole portal for more flexibility. Someon might want to access the other aspects too.
from ingress-intel-total-conversion.
adding a new field doesn't break compatibility when it comes to the API - passing a different data structure to an existing field does.
Also, just because we have no plugins using the API, it doesn't mean that others don't. There are many plugins out there, some developed for personal use, some for use within regional communities, and some elsewhere on Github.
@Fragger's change has been accepted and I'm closing this for now. We can always add more new fields later if the need arises for additional data - including one such as "portalv2: ent" if a need for the larger data structure is required.
from ingress-intel-total-conversion.
Related Issues (20)
- Site URL needs updating? HOT 2
- Won't return iitc after login on android HOT 1
- Is there anyone from developers? HOT 7
- I Cannot get IITC to run on Mozilla or Chrome HOT 5
- Is this app still developed? HOT 6
- Developers telegram or other chat? HOT 13
- Not working anymore? HOT 5
- Can't use facebook login to intel with IITC on android HOT 1
- IITC stomps on the jqueryUI resizable option HOT 1
- Niantic broke it? HOT 1
- Restore deleted portal? HOT 4
- Add support for Ingress's newly-released layers for explorer and pioneer activity HOT 4
- Portal history in IITC HOT 2
- layer-count plugin broken when draw-tools is also installed HOT 1
- IITC broken reditect is going to website HOT 2
- Layers not related to portal levels are also included in the target. HOT 1
- Player Tracker Plugin - Exclude "__MACHINA__" and/or Team "NEUTRAL" HOT 1
- agent's pin doesn't work well HOT 1
- Share portal info screen keeps popping up HOT 1
- disallowed_useragent ?!? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ingress-intel-total-conversion.