Giter VIP home page Giter VIP logo

Comments (4)

IJustDev avatar IJustDev commented on June 11, 2024

Thanks for creating this issue.

I think your problem could be solved by modifying following line:

return 'http://' + this.domain + ':' + this.port + '/api/v1/repos/' + this.owner + '/' + this.repo + '/issues';

If you don't use SSL, your API-request URL will look like this:
https://myservername.com/gitea:PORT

So if you specified a port you can check if it works once clearing out the port field.
Otherwise please reply and I will try to fix it asap.

from gitea-vscode.

schoel-bis avatar schoel-bis commented on June 11, 2024

Thanks for taking the time to look into this.

Alright, so that code helped a lot: The problem for me was, that I specified my user account as the repo owner instead of the owning organisation. Since the site is on SSL all was fine once I changed that. I am delighted by the now working extension; this is going to simplify things quite a bit.

It would have helped if the extension had somehow logged the request URL in case of an error or included it in the error message.

Yet, the line you are citing for non-SSL will probably not work with such a setup (i.e. installed to a sub-path) as the colon will still get appended to the path. You will get something like http://myserver.com/gitea:/api/v1/…. I am therefore leaving this issue open and leave the decision whether to close it as an irrelevant edge-case to you.

from gitea-vscode.

IJustDev avatar IJustDev commented on June 11, 2024

It's everything else than irrelevant :) Thanks for opening and I'm glad I could help.

  • I would suggest throwing an error with following message: "An HTTP error occoured. Please check your repository url."
  • Furthermore to fix the case when using an subpath I would try to include a setting for the subpath, or just let the user enter his repository url all at once so that there are no complications anymore with the port setting.

What do you think?

from gitea-vscode.

schoel-bis avatar schoel-bis commented on June 11, 2024

I am glad you see it that way. To reply to your suggestions:

  • It would have helped me a lot with my problem if the actual URL that caused the failure had been displayed somewhere, possibly along with an HTTP status code, whether in the VSC error popup or on the command line log (what is printed to the underlying terminal if you run VSC with code --verbose).

  • And I think I would opt for an additional setting for a "URL path to Gitea" or so as I think it is less than obvious if you have to add it to the domain name. After all, it is not a part of the domain name.

Just my 2 cents. Hope it helps a bit.

from gitea-vscode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.