Giter VIP home page Giter VIP logo

Comments (5)

codeislife99 avatar codeislife99 commented on May 13, 2024 3

@timmeinhardt - You have to use the Bernoulli Distribution and therefore can't be based off of the Categorical distribution.
You can use this piece of code
You have to add this in the model.py file

from distributions import Bernoulli
...
class Policy(nn.Module):
...
    elif action_space.__class__.__name__ == "MultiBinary":
        num_outputs = action_space.shape[0]
        self.dist = Bernoulli(self.base.output_size, num_outputs)

You have to add this in the distributions.py file

FixedBernoulli = torch.distributions.Bernoulli
log_prob_bernoulli = FixedBernoulli.log_prob
FixedBernoulli.log_probs = lambda self, actions: log_prob_bernoulli(self, actions).sum(-1, keepdim = True)
entropy = FixedBernoulli.entropy
FixedBernoulli.entropy = lambda self: entropy(self).sum(-1)
class Bernoulli(nn.Module):
    def __init__(self, num_inputs, num_outputs):
        super(Bernoulli, self).__init__()

        init_ = lambda m: init(m,
              nn.init.orthogonal_,
              lambda x: nn.init.constant_(x, 0),
              gain=0.01)

        self.linear = init_(nn.Linear(num_inputs, num_outputs))

    def forward(self, x):
        x = self.linear(x)
        return FixedBernoulli(logits = x)

from pytorch-a2c-ppo-acktr-gail.

ikostrikov avatar ikostrikov commented on May 13, 2024

There are no plans currently to add support for MultiDiscrete actions.

But I will gladly accept a PL!

I'm not sure whether there are any blocking factors but MultiDiscrete actions are clearly useful so I can help to fix any problems.

from pytorch-a2c-ppo-acktr-gail.

ShaniGam avatar ShaniGam commented on May 13, 2024

@codeislife99 Thank you for this!
Do you know how to implement FixedBernoulli.mode?

from pytorch-a2c-ppo-acktr-gail.

codeislife99 avatar codeislife99 commented on May 13, 2024

@ShaniGam. For implementing a Bernoulli mode you have to choose your own threshold probability for each action. During testing, it would be better to just sample instead of using mode. If it's a stochastic environment then mode would not even be close to what you want.

from pytorch-a2c-ppo-acktr-gail.

timmeinhardt avatar timmeinhardt commented on May 13, 2024

We now implemented a Bernoulli mode in form of a threshold. However, @codeislife99 's concerns should be considerer when using the Bernoulli distribution.

from pytorch-a2c-ppo-acktr-gail.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.