Giter VIP home page Giter VIP logo

Comments (4)

ikostrikov avatar ikostrikov commented on May 26, 2024

from pytorch-a3c.

beduffy avatar beduffy commented on May 26, 2024

Hey, that's good to hear. I can create this PR. I've been adapting your great code in another project and have been adding docstrings to some functions and classes e.g. this ASCII art architecture to the ActorCritic class:

Implementation of A3C (https://arxiv.org/abs/1602.01783).

____________________________________________________________________________________________________

                            A3C policy model architecture

   Image Processing module -> Flattened output ->     Policy Learning Module    --->  Final output
           ______________________                ___________________________________
          |     _______    ____ |     __       |      ___________                 |
image ->  | 4x |conv2d| + |ELU| |    |__|      |     |   LSTM   | --> Critic FC-> | -> value
          |    |______|   |___| | -> |__| -->  | --> |__________| --> Actor FC -> | -> policy logits
          |                     |    |__|      |        ^   ^                     | -> (hx, cx)
          |                     |    |__|      |        |   |                     |
          |_____________________|              |  prev cx  hx                     |
                                               |__________________________________|
____________________________________________________________________________________________________

    Processes an input image (with num_input_channels) with 4 conv layers,
    interspersed with 4 elu activation functions. The output of the final layer is then flattened
    and passed to an LSTM (with previous or initial hidden and cell states (hx and cx)).
    The new hidden state is used as an input to the critic and value nn.Linear layer heads,
    The final output is then the predicted value, action logits, hx and cx.
    """

I can add a few things like this if you want in the PR? But otherwise if you just want the name change, I can do that as well

from pytorch-a3c.

beduffy avatar beduffy commented on May 26, 2024

I created the PR here with the typo fix:
#61

If you would like the ASCII art and some other documentation, happy to create another PR.

from pytorch-a3c.

beduffy avatar beduffy commented on May 26, 2024

Thanks for merging the PR!

I assume I'll sell my ascii art on the black market to the next highest bidder? 😛 I'm happy to close this issue.

from pytorch-a3c.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.