Comments (4)
oyvindln
commented on June 11, 2024
Sounds reasonable, it was mainly used to verify stuff earlier during development, but it's not really needed anymore.
Would it be enough to move the dependency under a feature (there is already a benchmark feature), or does it need to be removed entirely from the main crate?
from deflate-rs.
JohnTitor
commented on June 11, 2024
What's the status at now? It seems we depend on flate2 in some tests so we couldn't move it to benchmark feature as it is?
from deflate-rs.
oyvindln
commented on June 11, 2024
Could probably just add a separate feature for it if needed, this library is kind of in maintainance mode at this point anyhow. Also the test could be changed to use miniz_oxide to reduce then number of dev-dependencies.
from deflate-rs.
oyvindln
commented on June 11, 2024
Changed to use minz_oxide in 7b316c7 which should cut down on dev-dependencies.
from deflate-rs.
Related Issues (20)
- Proper writer behaviour
- Hash chains are not updated correctly in some cases. HOT 1
- deepin linux build error HOT 8
- Assertion error from fuzzing HOT 1
- debug assertion fails in writer.rs HOT 18
- Follow API guidelines
- dictionary support
- Port fast mode from miniz
- libflate link in README is broken HOT 1
- Panic on mips64 / mips64el HOT 4
- Panic in `ChainedHashTable::add_hash_value` when encoding HOT 2
- Remove use of deprecated mem::uninitialized HOT 1
- AFL crash HOT 3
- More AFL crashes HOT 3
- Internal assertion fails at images larger than 4800×4800 HOT 6
- Readme claims no unsafe but there is one HOT 1
- Flushing `ZlibEncoder` loops infinitely on some writers HOT 2
- v0.8.5 generates invalid PNGs HOT 7
- Is this project only for deflate usage? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deflate-rs.