Giter VIP home page Giter VIP logo

Comments (2)

emmanuelantony2000 avatar emmanuelantony2000 commented on August 16, 2024

We could check if the buffer contains all valid ascii values using the is_ascii function.
Then we could convert it to an &str and then trim it. Correct me if I am wrong.
Would this solve this issue? I would be happy to give a PR.

from image-tiff.

HeroicKatora avatar HeroicKatora commented on August 16, 2024

There are two checks that would need to be adjusted. You mentioned the first, all values should be checked against is_ascii. Additionally, the current implementation will optionally remove the final NUL-byte but it should require at least one such byte to exist before it is trimmed. Your approach sounds fine, I'd be glad to review a PR for this :)

from image-tiff.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.