Giter VIP home page Giter VIP logo

Comments (7)

phated avatar phated commented on July 20, 2024

I am also having this problem. I am using 0.1.4 which should work but they are pointing to master to fetch the binaries and that version doesn't work on CentOS since the newest GLIBC is 2.12.

from pngquant-bin.

phated avatar phated commented on July 20, 2024

What the 0.1.4 commit should have looked like - phated@24844b5

from pngquant-bin.

kevva avatar kevva commented on July 20, 2024

I built the binary on Ubuntu 12.10. But feel free to build another one and submit a PR. Or we can revert to the previous one.

@hillct, we can define different build options for every os and arch like this:

opts: {
    buildScript: '<main build script>',
    platform: {
        centos: {
            buildScript: '<centos build script here>',
            arch: {
                x64: {
                    buildScript: '<x64 specific centos build here>'
                }
            }
        }
    }
}

from pngquant-bin.

phated avatar phated commented on July 20, 2024

The binaries should be versioned with the releases. Otherwise reverting or
locking at a specific version doesn't work for people.
On Oct 17, 2013 11:46 AM, "Kevin Mårtensson" [email protected]
wrote:

@hillct https://github.com/hillct @phated https://github.com/phated,
I built the binary on Ubuntu 12.10. But feel free to build another one and
PR.


Reply to this email directly or view it on GitHubhttps://github.com//issues/12#issuecomment-26537808
.

from pngquant-bin.

kevva avatar kevva commented on July 20, 2024

@hillct @phated, could you test and see if one these binaries work https://github.com/sindresorhus/node-pngquant-bin/tree/db7b9f952488650250a9b95c9aecf2300b3a14e0/vendor/linux?

from pngquant-bin.

phated avatar phated commented on July 20, 2024

yes, the old ones work. That is why i am saying your binaries should be versioned also. Please see my linked commit to how it should be.

from pngquant-bin.

kevva avatar kevva commented on July 20, 2024

24180cc

I have reverted the Linux x64 binary to the old one and the binaries now points to tags. Hopefully it's fixed now.

from pngquant-bin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.