histogram1d about imglib2 HOT 8 CLOSED

Another option would be add a dependency on imglib2-algorithms to imglib2-ops. This might be preferred since there was significant discussion about whether histograms belong in core during the last hackathon, and IIRC the primary ImgLib2 authors wanted the histograms outside core. (Personally I do not care much either way, although I think histograms are rather "core" as far as usefulness goes.) @bdezonia is currently on vacation but will comment when he returns. Anyone else have a preference?

from imglib2.

Hi all,

I also remembered the discussion regarding where to place histograms. I think we agreed to put them outside core for now because it wasn't necessary at the time. I think no one had really strong opinions either way.
So now that the need comes up, I think we should move it to core (or to ops, I don't mind).
I think that op's should not depend on algorithms. I fear that would at some point in the future cause ops to pull in a lot of transitive dependencies that are not really needed.
So I prefer putting histogram in core.

Of course, ops and algorithms are quite related and we might also think about a complete restructuring at some point. I could imagine imglib2-ops only containing interfaces and stuff needed for chaining ops etc and
all the op implementation going into imglib2-algorithms.

best regards,
Tobias

On Jun 20, 2013, at 6:16 PM, Curtis Rueden [email protected] wrote:

Another option would be add a dependency on imglib2-algorithms to imglib2-ops. This might be preferred since there was significant discussion about whether histograms belong in core during the last hackathon, and IIRC the primary ImgLib2 authors wanted the histograms outside core. (Personally I do not care much either way, although I think histograms are rather "core" as far as usefulness goes.) @bdezonia is currently on vacation but will comment when he returns. Anyone else have a preference?

—
Reply to this email directly or view it on GitHub.

from imglib2.

OK, if @tpietzsch is OK with histograms going into core, I vote we move them there. 👍

@MichaelZinsmaier, if you want to move the code, go ahead and file a PR for it. Otherwise, @bdezonia can do it next week after he returns from vacation.

from imglib2.

I wait for @bdezonia s return from vacation, than he can decide where in the core it fits best (maybe util)

from imglib2.

Personally I like net.imglib2.histogram.

from imglib2.

Sounds good.

On Jun 24, 2013, at 10:55 AM, Curtis Rueden [email protected] wrote:

Personally I like net.imglib2.histogram.

—
Reply to this email directly or view it on GitHub.

from imglib2.

All, I have moved the histogram classes into net.imglib2.histogram in core.

from imglib2.

Thanks @bdezonia!

from imglib2.