Comments (3)
Thanks for pointing these out, Barry! Both are clearly bugs. I just pushed the fix.
I fixed the copy constructor and removed the AbstractRealInterval(double[] dimensions) constructor.
The way we defined it, min and max are inclusive. So for (integer) Interval with min=0, dimensions=max+1.
Because every Interval is also a RealInterval, we decided that RealInterval has no dimensions() method (exactly because the dimensions=max+1 makes no sense here). Therefore the (double[] dimensions) constructor also makes no sense.
The alternative would have been to define min as inclusive and max as exclusive. Maybe we should have done that, now it would be a lot of work to change it (but not impossible)
from imglib2.
Thanks for the fixes Tobias. Shall we close this issue? Or did you want feedback on the exclusive max idea?
from imglib2.
Sorry, Barry. I just forgot. I'll close the issue now. Feedback on exclusive vs inclusive max is welcome though :)
from imglib2.
Related Issues (20)
- Building a kdTree is slow for repeated values HOT 1
- More specific type hierarchy for volatile types
- Remove unnecessary overrides of IterableRealInterval.iterator()
- Spliterators for standard NativeImgs
- Create LocalizableSamplerStream HOT 4
- Explore consequences of adding ImgLibStream wrapper HOT 1
- Stream API documentation
- Improve Point.setPosition
- Consistent toString() implementations
- Deprecate AbstractLocalizingCursor
- Simplify AbstractArrayCursor hierarchy
- Reduce allocation size for Cell objects in CellImg
- Add Util.printCoordinates(Localizable)
- Implement CellLocalizingSpliterator and PlanarLocalizingSpliterator
- Simplify static creation methods
- Views.bundle returns BundleView, but BundleView class is not public HOT 3
- Modularize core ImgLib2 projects HOT 1
- Improve Intervals methods
- WriteConvertedCursor constructor fails with ArrayIndexOutOfBoundsException HOT 6
- Add documentation for SamplerConverter
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from imglib2.