Giter VIP home page Giter VIP logo

Comments (4)

alextran1502 avatar alextran1502 commented on July 30, 2024 1

We can solve this right before going stable to avoid making unnecessary breaking changes to others setup now

from immich.

a10kiloham avatar a10kiloham commented on July 30, 2024

Proposed solution here - #11378

from immich.

mmomjian avatar mmomjian commented on July 30, 2024

So, most instances of docker will resolve either the container name, hostname, or service name (which is redis) to the container.

With that said, I've felt that we should fix this issue before we go to stable. I would propose something different than your PR, though. I've seen a lot of people have this issue come up.

I honestly think we should specify the service name, container name, and hostname for every service to all be identical. Something like immich-server, immich-redis, immich-postgres. (you can't use _ in hostnames). At the same time we could add those as the hostnames to the default env file, and it shouldn't break old installs. Whether this will actually happen is a big question.

Example:

services:
  immich-server:
    container_name: immich-server
    hostname: immich-server
    image: ...

from immich.

a10kiloham avatar a10kiloham commented on July 30, 2024

Yeah these are all inelegant options. I have a legacy container named redis and this is what tripped me up. The correct way is indeed immich-redis style naming I agree. Your proposal makes the most sense but will lead to some breaking changes I suppose.

from immich.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.