Option type fields allow nulls about immutables-vavr HOT 7 CLOSED

I have a patch for it if it helps, it's relatively straightforward to add a few checks for not null.

from immutables-vavr.

Definitely a bug. I think part of the problem is that I didn't realize vavr's Option type would accept null values.

from immutables-vavr.

Just found the same bug if the member is annotated with @Value.Parameter, there's no null check in the constructor. So:

@Value.Immutable
@VavrEncodingEnabled
public interface SomeObj {
    @Value.Parameter
    String someString();

    @Value.Parameter
    Option<String> someOptionString();
}

SomeObj o = ImmutableSomeObj.of("hello", null);
// Should throw a NullPointerException, but doesn't

Not totally sure where to fix this, looking now.

from immutables-vavr.

Found it, needs an @Encoding.Of adding.

from immutables-vavr.

yep, by default it's just passing the parameter to a field, if any check or conversion need to be added - @Encoding.Of is the way

from immutables-vavr.

PR coming up. Sorry I was too slow to get this into v0.6.1!

from immutables-vavr.

I think this is fixed. Thanks so much for the quick response!

from immutables-vavr.