Comments (2)
It may be a little bit weird, so what it does, it consider each supertype and then the same type and uses runtime bits to avoid pulling things already set. It doesn't do good analysis of what properties subtypes are covered and which are not (again - runtime check). And I don't remember for sure, but we're probably skipping supertypes with Generic parameters to avoid unsoundness/heap pollution. In the given example, it seems clear that the check like if (object instanceof LastModified<?>)
and pulling lastModified()
should be fine (as no type parameters used on this accessor). So maybe this can be fixed, given that generic will be properly handled (i.e. allow only wildcard like from(LastModified<?> )
and only using attributes with no type parameter used in return type). I guess this seemed a bit not trivial, so were originally omitted. I'll revisit this part to see how hard it will be to improve the handling, but it will take time
from immutables.
Thanks so much for looking at this. In the meantime, we refactored our code to avoid this specific problem, so we are not in a rush to get it fixed. But it feels like a pitfall other users might run into as well, even if it is a bit of an edge case.
from immutables.
Related Issues (20)
- implementation type not visible when using @Criteria and ImplementationVisibility.PACKAGE
- @Value.Default
- How to reducing annotation clutter?
- Using strict builders gives Jackson deserialize failures
- Issue with nested quotes in strings when using passAnnotations HOT 1
- Underriding toString will select invalid static method in preference to valid default method HOT 1
- cannot find annotations noise
- xor options HOT 2
- from method HOT 2
- "Sandwich" style immutables in combination with Jackson and Set-type properties leads to compile time warnings in generated code HOT 1
- passAnnotations patterns HOT 2
- Better Support for Jackson's @JsonSubTypes HOT 1
- @Encoding doesn't work on Java 17+ HOT 2
- Initialize a builder from existing instance HOT 2
- Possible to generate a nested "namespaced" hierarchy using @Value.Enclosing (or another approach)? HOT 1
- Feature: Style Annotation Support for @Redacted
- Adding swagger.parser.v3 breaks my generation of immutables HOT 2
- jakarta.annotation.Nullable is not being considered with @Builder.Constructor
- Compile time immutability HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from immutables.