Giter VIP home page Giter VIP logo

Comments (3)

garrensmith avatar garrensmith commented on June 1, 2024 1

Awesome. No rush let me know if I can help.

from mobc.

garrensmith avatar garrensmith commented on June 1, 2024

@dcormier Good investigating. Would you like to submit a fix for this?

from mobc.

dcormier avatar dcormier commented on June 1, 2024

Thank you, @garrensmith.

Yes, I would like to. Right now I'm looking at addressing two things:

  1. Treat max_idle == 0 as unlimited idle connections. In this case, open connections will be limited by max_open.
  2. Allow Builder to be configured with max_idle > max_open when max_open == 0, matching the behavior of Pool::set_max_idle_conns() (see snippet below).
    pub async fn set_max_idle_conns(&self, n: u64) {
        let mut internals = self.0.internals.lock().await;
        internals.config.max_idle =
            if internals.config.max_open > 0 && n > internals.config.max_open {
                internals.config.max_open
            } else {
                n
            };

I think it'll be a couple of days before I have time to get all the tests in place to ensure the behavior is what's expected.

from mobc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.