Comments (3)
Awesome. No rush let me know if I can help.
from mobc.
@dcormier Good investigating. Would you like to submit a fix for this?
from mobc.
Thank you, @garrensmith.
Yes, I would like to. Right now I'm looking at addressing two things:
- Treat
max_idle == 0
as unlimited idle connections. In this case, open connections will be limited bymax_open
. - Allow
Builder
to be configured withmax_idle > max_open
whenmax_open == 0
, matching the behavior ofPool::set_max_idle_conns()
(see snippet below).
pub async fn set_max_idle_conns(&self, n: u64) {
let mut internals = self.0.internals.lock().await;
internals.config.max_idle =
if internals.config.max_open > 0 && n > internals.config.max_open {
internals.config.max_open
} else {
n
};
I think it'll be a couple of days before I have time to get all the tests in place to ensure the behavior is what's expected.
from mobc.
Related Issues (20)
- redis::cmd.query_async does not work with mobc pool HOT 3
- Possible pool depletion and elevated number of timeouts HOT 1
- Adding Support for Redis Cluster Async HOT 1
- Pool should check for max idle lifetime in cleaner
- Incompatible with latest stable actix-web HOT 4
- Mobc should report errors HOT 1
- mobc completely stops serving connections. HOT 6
- New features require- Provide an Async function callback when deleting a Connection
- Access to mobc
- mobc-postgres page on crates.io links to archived repository HOT 1
- Metrics related to opened connections are registered incorrectly HOT 1
- Allow use of latest `redis` patch release HOT 1
- Please release new version of `mobc-redis` HOT 2
- `mobc_pool_connections_idle` reports "connection limit" on start, and "connections left to connection limit" later HOT 6
- Debug for Pool struct HOT 5
- Metrics crate needs to be bumped to fix ahash compilation failure on Rust Nightly HOT 2
- `mobc-redis` need update
- Why weren't the previous two connections reused, but instead two new connections were created?
- max lifetime does not work
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mobc.