Platform: windows port about diskonaut HOT 10 CLOSED

I made filesize as a cross-platform way of getting the size of objects on disk.

Termion looks to be getting there.

from diskonaut.

Hey @Freaky, I saw your PR and will take a look at it shortly regarding filesize. Thanks for this!

Since diskonaut uses tui-rs, I think we can definitely switch the backend to crossterm or something that supports windows with a conditional compilation flag. So even if it takes a while for that Termion issue to be merged, I think we can still go forward with this.

from diskonaut.

So to update this issue: thanks to @Freaky, 1 has been taken care of. We are left with 2.

from diskonaut.

what the state here. I have a rough version working with crossterm on windows. Is this interesting or are you waiting for termion to get a working windows version.

Could either switch 100% to crossterm, or make the backend choice a feature. I dont know enough to be able to say whats best, easiest is 100% switch

from diskonaut.

Very interesting! I'd be happy to move 100% to crossterm (we've recently done something similar with bandwhich) if it gives us windows support. Only thing is I'd like to manually test it on linux/mac first to make sure it's okay, because our tests mock the tui backend.

from diskonaut.

ok, this is 100% switch to crossterm, runs on my windows 10 dev box and on my rasp pi.

The tests dont even compile so I have not sent you a pull request. But you can check it out here https://github.com/pm100/diskonaut

Let me know if you find anything broken

from diskonaut.

BTW - I found this project via 'this week in rust' projects looking for help.

Total rust noob.

from diskonaut.

tests now compile. they all fail, I dont know how they work so not sure how to fix. You seem to be testing to see what draw commands are issued, hers the failure on the first test i drilled into

thread 'tests::cases::ui::two_large_files_one_small_file' panicked at 'assertion failed: `(left == right)`
  left: `[Clear, HideCursor, Draw, HideCursor, Flush, Draw, HideCursor, Flush, Clear, ShowCursor]`,
 right: `[Clear, HideCursor, Draw, Flush, Draw, Flush, Clear, ShowCursor]`', src\tests\cases\ui.rs:106:5

I wonder if this is just a difference of how tui drives the backend, not sure.

from diskonaut.

Hey @pm100, I took a brief look at the repo and it looks like a great start! I haven't yet tested this locally though, and if you'd like to move forward with this I'll definitely take a closer look.

About the tests: it definitely might be. I wouldn't worry too much about these (you can even comment them out for now) and would more try to concentrate on the snapshots. These are snapshots taken of the UI in each draw event (as a delta of what was on the screen in the previous draw event). They should not be very different and should make it easier to understand what changed.

Do feel free to open a PR though, even with failing tests. I think it will make it easier for us to discuss.

Also - I'm happy you found this project and want to work on this. No worries about experience levels, I think you're doing great. :)

from diskonaut.

Released in 0.11.0, thanks @pm100 !!

from diskonaut.