Comments (8)
As the one responsible for the current code.. Agreed!
from arraycontext.
IIUC, you're proposing that ArrayContext.{from,to}_numpy
should support containers?
from arraycontext.
IIUC, you're proposing that ArrayContext.{from,to}_numpy should support containers?
No, just that the logic of what array types are legal to be frozen must be moved the respective implementations. I found this condition:
to be quite restrictive, as we couldn't convert cl_arrays to NumPy arrays for PytatoPyOpenCLArrayContext.from arraycontext.
For my understanding, why doesn't PytatoPyOpenCLArrayContext
advertise support for both the frozen and unfrozen array types? i.e. for both pt.Array
and cl.Array
.
from arraycontext.
Agree with @alexfikl, that seems like a relatively clean thing to do.
from arraycontext.
That was because operations like pt.Array+cla.Array aren't defined.
from arraycontext.
That was because operations like pt.Array+cla.Array aren't defined.
I think that's alright. array_types
just says "these are the possible types that come out of this". It doesn't need to entail a promise of interoperability.
- If we decide we like this disclaimer, we should add it to the docs.
from arraycontext.
I agree, I like this. I'll change #160 to implement this. Thanks to both!
from arraycontext.
Related Issues (20)
- Handling temperature initial guesses
- Deprecate `is_array_container` HOT 7
- CI failing in mypy HOT 1
- `actx.compile` for pytato should allow things that are not array containers HOT 2
- Dealing with constants in `freeze`
- Issues with `zeros` et al functions of array contexts HOT 4
- Make it so array containers do not know their array context? HOT 8
- Make a way to ensure we always use the actx's allocator
- Regression: "Out of host memory" on Nvidia ICD HOT 4
- Exposing `np.select`? HOT 1
- Function outlining errors in mirgecom
- Add optional `allow_single_version` Boolean arg to `actx.compile` HOT 12
- Precision: What actually do `freeze`/`thaw` mean?
- `(zeros|ones|full)_like` and `axes`/`tags` HOT 2
- `test_array_context_np_workalike` may be flaky HOT 1
- Introduce a `-O0` mode to avoid full-blast code transformation for code that runs once
- Loopy a hard dependency? HOT 1
- eager arraycontext bug
- Renaming parts of partitioned DAGs HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from arraycontext.