Giter VIP home page Giter VIP logo

Comments (7)

dzhuang avatar dzhuang commented on May 28, 2024

I see there's a parse_date_spec function with return_now_on_error default True. Seems the reason is parse_date_spec failed to parse the time and return now() as the results.

from relate.

inducer avatar inducer commented on May 28, 2024

Right. The reason for this whole mess is that when you first create a course that relies on a bunch of events, all of these events are not known, because the course needs to exist first in order for you to create the events. On the other hand, the course content doesn't make sense without the events in place. That's a circular dependency, and it needs to be broken somehow.

The way I chose to do that was by parsing unknown events as "right now" (the flag you found) and letting the user check which date/time fields encountered an error while parsing. (Content > Check Events) If you've got a better suggestion, I'd be happy to hear it.

But even with the existing feature, I think the UI could stand to be renamed and reshuffled a bit. (Possibly: Check date validity?) I'll work on that.

from relate.

inducer avatar inducer commented on May 28, 2024

47a5b91 should significantly improve the usability of this. Unrecognized date/time specifications now generate warnings during update, which is more natural (and more visible) than the hidden "check events" feature.

from relate.

dzhuang avatar dzhuang commented on May 28, 2024

Validation failed for course content for flows using time with the ISO format since your latest commit. Maybe I should dive into the logic and relationships between events and time setting. Thank you.

from relate.

inducer avatar inducer commented on May 28, 2024

Should be fixed in 2e1426e, tested in sample content:

inducer/relate-sample@03f9f6c

from relate.

dzhuang avatar dzhuang commented on May 28, 2024

Now I can be confident to say I understand the relationship between events and time rule, I think it's really a good idea! Thank you. Now the problem is, under what circumstance will the ISO format time function?

from relate.

inducer avatar inducer commented on May 28, 2024

It'll be viewed as an ISO timestamp if YAML parses it as one.

See example 2.22 here:
http://www.yaml.org/spec/1.2/spec.html#id2761292

from relate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.