useMutation first parameter type error about datx HOT 4 CLOSED

The issue with this error is that createPost method is using client.request. The return type of client.request is a Response which has either to one or to many relationship. With @datx/swr we have created 2 new responses - SingleResponse and CollectionResponse. To use them, change the client.request to client.requestSingle or client.requestCollection and the type will be correct.

I tried to override the request method to enhance the DX with this PR but there are other issues that occurred and that are not that easy to solve quickly since a lot of internals are using client.request and we are doing castings on another level.

Next idea is that to create a eslint rule to solve throw an error when developer is using client.request in a project that has @datx/swr installed, what do you think about that?

One other solution is to check if a client.request has been called with fetchOptions: { Response: CollectionResponse/SingleResponse } which will indicate that this is an okay call to make and throw an error if called without - but that does not seem right and this is also causing us to ship more code just to fix the typing issues.

@isBatak @DarkoKukovec @doroz0 what you say on all of this?

from datx.

I didn't notice many places where we're using the request method internally. I changed this behavior and updated a test that failed, and everything seems to be working fine?
94978ed

from datx.

Thanks a lot, @DarkoKukovec :D Would this be considered a breaking change if we are throwing errors?

from datx.

Yeah, I guess so... 🤔
#1179 is also still pending because it is a breaking change

from datx.