Giter VIP home page Giter VIP logo

Comments (5)

JakubSerwatka avatar JakubSerwatka commented on May 28, 2024 2

Hey, didn't have much time to look at it, so I skipped more complicated resources (Compute Engine + Networking) and focused on the simpler ones. Here are my finds so far.

Artifact Registry

  • Africa continent missing in network traffic calculation

BigQuery

  • Missing support for location argument

BigQuery Dataset

  • Multi-region not supported

BigQuery Table

  • Multi-region not supported for multiple cost components
  • Potential incorrect region attribution due to r.mapRegion()
  • Storage read API appears to not support regions correctly (judgement based on non regexed attribute filter)

Cloudfunctions

  • Missing 2nd gen support

Compute Image

  • Missing support for storage_locations argument

Compute Snapshot

  • Missing support for storage_locations argument

As far as the testing region goes, it seems that usually the newer ones get special treatment, but that is not a guarantee. I'd suggest testing at least one region from every continent, as well as multi regional resources. Additionally, I suggest testing at least one non-provider default region, they aren't always attributed correctly due to non region arguments in resources.

from infracost.

jakubserwatka-oktawave avatar jakubserwatka-oktawave commented on May 28, 2024 1

I'll go over all existing resources for GCP and verify that there are no other existing cases like this. From quick check I can see that there are some resources that handle it correctly, for example bigquery_dataset.go with

AttributeFilters: []*schema.AttributeFilter{
  {Key: "description", Value: strPtr(fmt.Sprintf("Analysis (%s)", r.Region))},
},

I will also check if this separation of pricing is consistent for any specific region, that way it can be added to tests and suggested for any new resources.

from infracost.

vdmgolub avatar vdmgolub commented on May 28, 2024 1

Thank you for digging into it, great stuff! ❤️ I'll bring your suggestions to the team to improve the test coverage for different regions.

The fix for the compute address is in the master already. We'll keep this issue open until the new release is out. We'll post a comment, so you should be notified when you can upgrade. Thanks again for all your help! :)

from infracost.

vdmgolub avatar vdmgolub commented on May 28, 2024

@jakubserwatka-oktawave Hey! Thanks a lot for creating the issue! I've confirmed that's an issue for the google_compute_address resource. Tweaking the attribute filter should accommodate all the cases, I've created a PR for that.

You mentioned that other resources can have a similar issue too. Could you please list them here if you encountered them here? We're not using Google resources ourselves, especially across different regions, so we rely on the community to report such cases. I really appreciate any help you can provide. :)

from infracost.

aliscott avatar aliscott commented on May 28, 2024

@jakubserwatka-oktawave thanks for reporting this 🙏 The fix for compute address is now released in v0.10.31.

from infracost.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.