Giter VIP home page Giter VIP logo

Comments (7)

infusion avatar infusion commented on June 11, 2024

What do you mean by handling it with the options file? Throwing an exception is meant to push the admin more rigoros on the issue, which might be an inacceptable behavior in some cases. Do you want to have a default case instead of throwing?

from node-dhcp.

nistorj avatar nistorj commented on June 11, 2024

Yes, I think that's what I was trying to convey, a default case would be perfect. :>

from node-dhcp.

infusion avatar infusion commented on June 11, 2024

Hmm, I think it's hard to define a default case since all unimplemented options have different types. What I can think of instead of throwing an error I could just invoke the error handler, so you can catch these cases with on("error")

from node-dhcp.

nistorj avatar nistorj commented on June 11, 2024

that would be perfect, logging the info works perfectly fine too. It's impossible to cover every use-case but we also don't want the system to die out when it can't handle something. Never know what kind of junk devices request these days!

from node-dhcp.

infusion avatar infusion commented on June 11, 2024

Yeah, you're absolutely right! I did it the hard way to see problems immediately while developing. But I will change it :)

from node-dhcp.

nistorj avatar nistorj commented on June 11, 2024

^--- best customer service right here.

from node-dhcp.

infusion avatar infusion commented on June 11, 2024

Thanks :) v0.2.18 just landed on npm.

from node-dhcp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.