Comments (7)
What do you mean by handling it with the options file? Throwing an exception is meant to push the admin more rigoros on the issue, which might be an inacceptable behavior in some cases. Do you want to have a default case instead of throwing?
from node-dhcp.
Yes, I think that's what I was trying to convey, a default case would be perfect. :>
from node-dhcp.
Hmm, I think it's hard to define a default case since all unimplemented options have different types. What I can think of instead of throwing an error I could just invoke the error handler, so you can catch these cases with on("error")
from node-dhcp.
that would be perfect, logging the info works perfectly fine too. It's impossible to cover every use-case but we also don't want the system to die out when it can't handle something. Never know what kind of junk devices request these days!
from node-dhcp.
Yeah, you're absolutely right! I did it the hard way to see problems immediately while developing. But I will change it :)
from node-dhcp.
^--- best customer service right here.
from node-dhcp.
Thanks :) v0.2.18 just landed on npm.
from node-dhcp.
Related Issues (20)
- Performance / Scale testing HOT 1
- Publish Docker image HOT 1
- bootFile: function(){} arguments not passed HOT 3
- Custom options (209, syslinux config file) HOT 4
- In example typo HOT 15
- macOS - Won't reach internet from created subnet [SOLVED - SEND MSG IF WANT TO KNOW HOW] HOT 2
- seqbuffer.js has a typo when trying to use Static IP with MAC addresses [DECIDED NOT TO FIX - MAIN CODE STAYS BROKEN]
- DHCP OFFER message missing / broken in Microsoft devices HOT 3
- Big Fork. HOT 19
- not suppport for MacOS HOT 6
- dhcp server stops listening for messages
- Need a SO_BINDTODEVICE to complete my fork. HOT 2
- Crashing on options in the reserved space
- features undefined on client
- Add support for MSFT option 249
- trying to get sock.address() data in to global variable
- Client Authentication
- invalid option undefined HOT 3
- Missing config-field for 60 and 61 HOT 1
- Having issues with broadcast HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-dhcp.