Calendar entries for contacts without birthYEAR about thunderbirthday HOT 7 OPEN

Yes, this is possible with a tiny change in the code.
I've sent @ingomueller-net by email a modified version on 28/01/2014 and 07/11/2014, but never got a response from Ingo.
I'm a bit familiar with Git (use it at work), but not yet familiar with GitHub. I've tried to create a new branch, but I think I don't have the permissions to do so.
I probably need to create a fork.

from thunderbirthday.

I managed to get Ingo's repository from GitHub onto my PC, created a new branch and made the change and committed it, but I'm not able to push it to GitHub: ERROR: Permission to ingomueller-net/ThunderBirthDay.git denied to Dirksche.

@ingomueller-net Would it be possible to give me permissions to push my branch onto GutHub, and to release a new version of ThunderBirthday with it? For years, several people are asking for birthdays with unknown year of birth to be shown.

The changes are:

--- a/src/js/calThunderBirthDay.js
+++ b/src/js/calThunderBirthDay.js
@@ -753,7 +753,9 @@ calThunderBirthDay.prototype = {
         var day = parseInt(abCard.getProperty("BirthDay", null),10);

         // This is also false when year, month or day is not set or NaN.
-        if (!(year >= 0 && year < 3000 && month >= 0 && month <= 11 &&
+        // 29/04/2016 Dirk Busse: added support for birthdays without year of birth
+        //                        (Allowed NaN for the year.)
+        if (!(((year >= 0 && year < 3000) || isNaN(year)) && month >= 0 && month <= 11 &&
               day >= 1 && day <= 31)) {
             MyLOG(5,"TBD: convert: date " + year + "-" + month + "-" + day
                   + " not valid");
@@ -895,10 +897,14 @@ function cTBD_getOccurencesFromEvent(aEvent, aRangeStart, aRangeEnd) {
         occurrences[i] = occurrences[i].clone();

         with (occurrences[i]) {
-            // append age to the title
-            var age = startDate.year - aEvent.startDate.year;
-            title += " (" + age + ")";
-            
+            // 29/04/2016 Dirk Busse: added support for birthdays without year of birth
+            //                        (Don't add the age if year of birth is unknown.)
+            if (!isNaN(aEvent.startDate.year) && aEvent.startDate.year != 0)
+            {
+                // append age to the title
+                var age = startDate.year - aEvent.startDate.year;
+                title += " (" + age + ")";
+            }
             makeImmutable();
         }
     }

from thunderbirthday.

Thanks a lot for your help and sorry for not replying! I am not using Thunderbird myself for years now, which is why I have little motivation to do anything else but maintenance fixes. Your patch looks good though and should be easy enough to integrate.

The Github model is this: create a fork, push your changes to your fork (you can push there because you own it) and then create a merge request (see here and here).

from thunderbirthday.

Hi Dirksche - seen as that you were able to resolve the birthday date without a year - would your skills also extend to adding in support for anniversary dates. Either as an added feature of ThunderBirthDay or as a new addon 'ThunderAniversary'

Thanks
Robin

from thunderbirthday.

Hello @robinsapiro,

Unfortunately, I'm having the same problem as Ingo. A lack of time.
Initially, I thought I could do some more work (like handling double-clicks on birthdays in the calendar), but I never found the time to do so.
I've only fixed the most annoying problem which was that birthdays from people with unknown year of birth have not been shown.
And it seems that @ingomueller-net still hadn't found the time to merge it into the main code-base and to release a new version.

Best Regards,
Dirk

from thunderbirthday.

@ingomueller-net If a new version is released due to @klemens changes, maybe this issue could also be fixed.

Currently I'm using a local version that combines the pull requests #11 and #5.
I have resolved the merge conflict with this patch. https://pastebin.com/JivWrpQu

from thunderbirthday.

I'd really appreciate this feature as well and would be very happy if it could be merged!

Best
Martin

from thunderbirthday.