More consistent naming convention about androidviewmodel HOT 5 CLOSED

Hi Dan. I agree, making the old methods deprecated might be confusing. I know it is a breaking change, but on the other hand, refactoring the code in existing projects should be very easy - developers just have to rename 3 methods. Maybe you can promote a version of the library to 1.0.0 to indicate the change in the API.

from androidviewmodel.

That's definitely a very good suggestion, and you are absolutely right - the naming isn't consistent. I am thinking how to do it without forcing developers to change their code, but there is probably no other way (I could make the old methods deprecated, but that would be just confusing).

from androidviewmodel.

Good idea, but changing onModelRemoved() to onDestroy() could be confusing, because this method is called when Activity or Fragment is finishing, not every time onDestroy() is called. So this one should stay as is or change to something like onRemove(), in my opinion.

from androidviewmodel.

That's a good point, but we are talking about ViewModel.onDestroy() which should be called when the ViewModel itself is being destroyed. The naming convention is consistent, the moment when it is called is a bit different (in relation with Activity/Fragment), but the method is called when the ViewModel is being destroyed (same behavior as Activity/Fragment), so in this matter, it makes sense. It is a similar situation as Activity vs. Fragment - for example Fragment.onCreate() is not called everytime when Activity.onCreate() is called (e.g. creating fragment instances in a view pager when you are swiping). I think it is not about when exactly it is called in the Activity/Fragment lifecycle, but rather in which situation it is called in ViewModel lifecycle.

I understand it might be confusing in relation with Activity/Fragment lifecycle, but still I think that onDestroy() name makes sense. It is just my personal opinion, onRemove() could be also good name, definitely better than onModelRemoved().

from androidviewmodel.

Fixed (will be part of 1.0.0 release)

from androidviewmodel.