Comments (5)
Hi Dan. I agree, making the old methods deprecated might be confusing. I know it is a breaking change, but on the other hand, refactoring the code in existing projects should be very easy - developers just have to rename 3 methods. Maybe you can promote a version of the library to 1.0.0 to indicate the change in the API.
from androidviewmodel.
That's definitely a very good suggestion, and you are absolutely right - the naming isn't consistent. I am thinking how to do it without forcing developers to change their code, but there is probably no other way (I could make the old methods deprecated, but that would be just confusing).
from androidviewmodel.
Good idea, but changing onModelRemoved() to onDestroy() could be confusing, because this method is called when Activity or Fragment is finishing, not every time onDestroy() is called. So this one should stay as is or change to something like onRemove(), in my opinion.
from androidviewmodel.
That's a good point, but we are talking about ViewModel.onDestroy() which should be called when the ViewModel itself is being destroyed. The naming convention is consistent, the moment when it is called is a bit different (in relation with Activity/Fragment), but the method is called when the ViewModel is being destroyed (same behavior as Activity/Fragment), so in this matter, it makes sense. It is a similar situation as Activity vs. Fragment - for example Fragment.onCreate() is not called everytime when Activity.onCreate() is called (e.g. creating fragment instances in a view pager when you are swiping). I think it is not about when exactly it is called in the Activity/Fragment lifecycle, but rather in which situation it is called in ViewModel lifecycle.
I understand it might be confusing in relation with Activity/Fragment lifecycle, but still I think that onDestroy() name makes sense. It is just my personal opinion, onRemove() could be also good name, definitely better than onModelRemoved().
from androidviewmodel.
Fixed (will be part of 1.0.0 release)
from androidviewmodel.
Related Issues (20)
- Documentation about inter-view-model communication HOT 4
- changing setModelView to onStart in sample HOT 1
- Communication between ViewModel and Model HOT 4
- Android Studio custom template HOT 1
- Checking for PlayServices HOT 1
- ViewModel object creation - use Dagger 2 HOT 8
- View and ViewModel as a parent class HOT 2
- AVM in Activity issue HOT 1
- IView implementation for an recyclerview's item
- forget ViewModelBaseBindingActivity ha?
- Generic view model HOT 3
- Nested fragments support
- java.lang.IllegalStateException: ViewModel is not ready. Are you calling this method before Activity/Fragment onCreate? HOT 2
- jCenter deprecation
- Context for ViewModel HOT 2
- Other open source projects using AndroidViewModel.... HOT 1
- How to get or inject context in viewmodel... HOT 2
- transfer this rx subscription code from View to ViewModel.... HOT 1
- Please help : "cannot resolve symbol 'T' HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from androidviewmodel.