Servershell attr command not working about serveradmin HOT 13 CLOSED

Yes, it does work. Thank you.

from serveradmin.

Hi Emre,

Thanks 😊.

The attr command should work. However there are some assumptions (left) which are specific to our configured servertypes and attributes.

I want to clean them up but did not have time yet or a good solution.

You could try adding the "state" attribute as this has the most hard coded dependencies.

I will check next week what the problem is here.

Thanks for your report!

from serveradmin.

Moin Emre,

I just tested it on my local computer. I added a few servertypes and attribute and made them visible via the Servershell attr command (see screenshot). This works for me.

What attributes and servertype do you use ?

from serveradmin.

I added an attribute typed "relation". Can you try that?

from serveradmin.

Works just fine for me. Do you see any difference to your setup ?

from serveradmin.

I tried exactly the same and the problem remained. I tried to find out why and noticed that there are two Javascript files named command.js. My browser is probably loading the wrong one. The problem goes away when I delete servershell/static/js/servershell/autocomplete/command.js.

from serveradmin.

Ah that makes sense.

I split the Javascript files up while the redesign to have an easier time for development. On the long term I wanted to have them merged and minified anyways so there it would not make a difference anymore but until then we could just rename one to a different name.

from serveradmin.

Can you please check if the linked PR fixes your problem @hasegeli ?

from serveradmin.

It doesn't fix the problem. I was wrong. Though definitely it has something to do with the autocomplete. The problem goes away when the JavaScript file for autocomplete is removed.

Also, it's worth noting that not only attr but none of the commands work on my Safari. They do work on Chrome.

Can you not reproduce it on Safari?

from serveradmin.

Can you not reproduce it on Safari?

We have a few people working with Mac OS but I am unsure if they work with Safari - I will ask them. Otherwise I have a private Mac where I can try to reproduce it (Give me a few days).

Also, it's worth noting that not only attr but none of the commands work on my Safari. They do work on Chrome.

It is at least a bug in terms of design then. Auto completion should not break basic functionality.

from serveradmin.

Hey @hasegeli,

I can reproduce this now on my Mac.

The problem is with Safari that it seems not properly handle events which we use to update variables such as command, and search term. The command is just always and empty string for Safari because it never changes. I am checking why now. It works on all other Browser though Google Chrome, Opera, Safari, Firefox ...

from serveradmin.

Okay I found the issue. The problem is that the change event is not fired in Safari when the auto completion is enabled. If it is disabled it works just fine.

-> https://github.com/innogames/serveradmin/blob/master/serveradmin/servershell/static/js/servershell/search.js#L83

from serveradmin.

Hey @hasegeli.

I could not really find out why Safari and other browsers like Epihany do not fire or bubble up the change event for the input if the auto completion is enabled. My Fronted/Javascript knowledge is too limited for this.

However I found a work around that should work. Can you please try it out and let me know if it works for you ?

from serveradmin.