group columns with undefined values are broken about reactdatagrid HOT 4 CLOSED

null and undefined are special since stringifying them ends up with the same value as stringifying empty strings.
Grouping is implemented via stringification, and a group key needs to be unique for a certain value.
So instead of poluting our codebase with all kind of weird checks, we have exposed column.groupToString and column.renderGroupTitle - you should use those to customize grouping to fit you specific needs - below you can find an example

const groupToString = value =>
  value === null
    ? '<null>'
    : value === undefined
    ? '<undefined>'
    : value || '<empty>';

const renderGroupTitle = value => {
  if (value === '<null>') {
    return 'NULL or whatever group title you need';
  }
  if (value === '<undefined>') {
    return 'UNDEFINED';
  }
  if (value === '<empty>') {
    return 'EMPTY';
  }
  return value;
};
const columns: TypeColumn[] = [
  {
    name: 'country',
    defaultFlex: 1,
    header: 'Country',

    groupToString,
    renderGroupTitle,
  },
  { name: 'firstName', defaultFlex: 1, header: 'First Name' },
  {
    name: 'age',
    type: 'number',
    defaultFlex: 1,
    header: 'Age',
    groupToString,
    renderGroupTitle,
  },
];

Let us know how it goes - should do the trick for even the most advanced use-cases.

from reactdatagrid.

The problem is not the display of the group string, the problem is the grouping is broken. It's not grouping correctly. ook at this screenshot for example (from the repro):

You can see that the group "usa" is collapsed, and yet there's an open subgroup beneath it. Isn't this a bug?

from reactdatagrid.

It is a bug for null and undefined values, but using the groupToString/renderGroupTitle pair of properties you can workaround those edge cases.

from reactdatagrid.

that did the trick, thanks :)

from reactdatagrid.