Extend cardano Wallet CLI with selected commands about cardano-wallet HOT 4 CLOSED

Add options for loading passphrases from files.

I don't believe this is necessary. My experience with CLI tools is that sometimes there is an option to read passphrase from stdin - and then user can redirect file to stdin or similar.

But adding option to store passphrase to the file might not be the wise thing - as it might lead to errors from the user:

• user might forget that there is a file with his passphrase
• user might forget to change file permissions of passphrase stored file

We can protect user from the later but there are other ways user can mess up so I would rather not add this option or if we really have to have this feature then reading from stdin should be enough

from cardano-wallet.

@piotr-iohk I just realized that we won't get any code-coverage with the CLISpec integration tests. Because stack only collects code-coverage for code that is executed through the test-suites (and here, it's executed through a separate executable).

There seems to be a way to instrument stack to generate coverage reports with extra inputs from other executables. I'll have a look and see whether I can get this to work with shc/coveralls as well!

from cardano-wallet.

I have added some integration tests for CLI #264 (however don't know if it's gonna work, in particular still not sure how to test cardano-wallet wallet create since it is a responsive cli)
Also planning actually to create some manual regression test suite and make it part of the Release Checklist. (especially for anything that cannot be covered by integration tests)

Anyway still it would be good perhaps to improve on the code coverage here -> https://coveralls.io/builds/23377405/source?filename=lib/cli/src/Cardano/CLI.hs

from cardano-wallet.

Added more integration tests. Still plan to add more, but we can close this one.

from cardano-wallet.