`bash: Argument list too long` when entering dev shell about haskell.nix HOT 7 CLOSED

Ok, while I can get into a shell by removing that line, I also get...

/nix/store/fbykv4hlfs6hdxmrfsl1vj4fw47ryb7g-ghc-shell-for-packages-ghc-9.2.7-env/lib/ghc-9.2.7/package.conf.d
    array-0.5.4.0
    base-4.16.4.0
    deepseq-1.4.6.1
    ghc-bignum-1.2
    ghc-boot-th-9.2.7
    ghc-prim-0.8.0
    integer-gmp-1.1
    pretty-1.1.3.6
    rts-1.0.2
    template-haskell-2.18.0.0

so I wonder if propagatedBuildInputs is needed for this?

from haskell.nix.

Ok, this seems to have done the job:

diff --git a/builder/ghc-for-component-wrapper.nix b/builder/ghc-for-component-wrapper.nix
index 3ad518fa..dd72b4b8 100644
--- a/builder/ghc-for-component-wrapper.nix
+++ b/builder/ghc-for-component-wrapper.nix
@@ -19,6 +19,11 @@
 let
   ghc = if enableDWARF then defaults.ghc.dwarf else defaults.ghc;
 
+  uniqueWithName = list:
+    lib.concatMap lib.unique (
+      builtins.attrValues (
+        builtins.groupBy (x: if __typeOf x == "set" then x.name or "noname" else "notset") list));
+
   inherit (configFiles) targetPrefix ghcCommand ghcCommandCaps packageCfgDir;
   libDir         = "$wrappedGhc/${configFiles.libDir}";
   docDir         = "$wrappedGhc/share/doc/ghc/html";
@@ -154,7 +159,7 @@ let
     inherit script targetPrefix;
     inherit (ghc) version meta;
   };
-  propagatedBuildInputs = configFiles.libDeps;
+  propagatedBuildInputs = uniqueWithName configFiles.libDeps;
   nativeBuildInputs = [ghc];
 } (''
     mkdir -p $out/configFiles

from haskell.nix.

The change in that commit does seems suspicious to me. It looks like it's adding all of the library dependencies to propagatedBuildInputs, which means that we're adding basically the whole transitive dependency closure of libraries in?

from haskell.nix.

We've also recently started hitting this. Going to try a commit before this, great sleuthing Ollie!

from haskell.nix.

There are now lots of propagated inputs in three places:

• The GHC env builder
• The component builder
• The haddock builder

I'm trying applying your patch in each place.

But it strikes me that we're just putting off the problem: propagated build inputs are going to get pulled from the whole dependency tree (right?) deduplicating the ones that we add to each node will help, but it's still potentially going to be a lot of stuff, and there might be duplicates introduced later as well.

from haskell.nix.

Okay, I applied it in all three places and it worked. Not sure what the best solution is here.

from haskell.nix.

@hamishmack please take a look tomorrow morning.

from haskell.nix.