[Bug]: When you import a static inner class, spoon converts it to a non-static import about spoon HOT 4 OPEN

Hi @honghao12 ! I tried reproducing it, but anImport.toString does evaluate to import static StaticTest3.StaticInnerTest1. This functionality was last touched in #5213 and it was also released in 10.4.0 so it should work on any release after that. However, if it is still not working for you, could you please reproduce the output as a pull request (ideally as a new testcase)?

from spoon.

In what version of Java is import static used to import classes as opposed to fields and methods? Does that even compile with javac? import static StaticTest3.StaticInnerTest1 looks like it should be a compile time error anyway. import StaticTest3.StaticInnerTest1 looks correct.

from spoon.

The relevant part of the JLS regarding that is § 7.5.3. It mainly mentions static members, which includes static nested classes. This becomes clear from the following sentence (emphasis mine):

It is permissible for one single-static-import declaration to import several fields, classes, or interfaces with the same name, or several methods with the same name and signature.

I don't know how well we have test coverage for that, but we should make sure that we get imports right for both static nested classes and non-static nested classes.

from spoon.

Today I learned. From what I understand, for a static inner class it makes no real difference anyway, and some coding standards (like Google's) explicitly forbid using a single static import for static one classes ("use normal import instead").

Of course SPOON should handle this correctly. But the result (the missing "static" keyword) should have no negative effect on the resulting code from a practical point of view in (nearly?) all cases.

from spoon.