Giter VIP home page Giter VIP logo

Comments (8)

insanum avatar insanum commented on July 17, 2024

I think this is a good idea. Just having the "-v" option dump out the event details before doing any google calendar magic will be a nice change.

from gcalcli.

maddn avatar maddn commented on July 17, 2024

Oh yeah - that's the best solution. I w as actually thinking about adding a different command. But this idea is much better. The import -v option doesn't need to do any Google stuff unless the user actually chooses [i]mport.

from gcalcli.

maddn avatar maddn commented on July 17, 2024

I've had a go at patching this myself. I couldn't get it to work using just the -v option, because there could be mulitple events, and after printing the details of each event, there is the option to import - so it's not that simple.

So instead I added an import -d option to dump the ICS details and exit. I couldn't use ImportICS / CreateEventFromVOBJ as it was because they require the gcalcli class (so the google authentication must be done), so I moved the verbose output parts into a common function just to print the event details. It's not ideal, since this duplicates the logic in CreateEventFromVOBJ, but couldn't think of a better way to do.

I'm sure you guys can do a better job, but I can send a pull request if you want?

from gcalcli.

tresni avatar tresni commented on July 17, 2024

Send a pull request and we can review. I've been making a number of changes
to that code anyway to support The icalendar library and other formats.

On Wednesday, February 27, 2013, Michael Maddern wrote:

I've had a go at patching this myself. I couldn't get it to work using
just the -v option, because there could be mulitple events, and after
printing the details of each event, there is the option to import - so it's
not that simple.

So instead I added an import -d option to dump the ICS details and exit. I
couldn't use ImportICS / CreateEventFromVOBJ as it was because they require
the gcalcli class (so the google authentication must be done), so I moved
the verbose output parts into a common function just to print the event
details. It's not ideal, since this duplicates the logic in
CreateEventFromVOBJ, but couldn't think of a better way to do.

I'm sure you guys can do a better job, but I can send a pull request if
you want?


Reply to this email directly or view it on GitHubhttps://github.com//issues/63#issuecomment-14175035
.

from gcalcli.

maddn avatar maddn commented on July 17, 2024

Ok I've sent pull request.

I've been having problems importing some ICS files (not related to changes I've made). I was going to raise a defect for it, but I can leave it for now if you're making changes to how this works, and retest it again after.

from gcalcli.

tresni avatar tresni commented on July 17, 2024

There are known issues with certain ICS files that come from vobject. For example a comma in a description actually has special meaning that vobject holds strictly to. I am working on a branch that uses icalendar, but that has it's own set of special issues, just seems to be a little more actively developed.

from gcalcli.

tresni avatar tresni commented on July 17, 2024

Does the new -d option implemented in #67 resolve this for you?

nm. #67 is your pull request so I'm going to go with yes ;-)

from gcalcli.

maddn avatar maddn commented on July 17, 2024

Sorry for replying to this so late, but I only just pulled these changes. The -d option is working great. Thanks!

from gcalcli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.