Giter VIP home page Giter VIP logo

Comments (10)

ViktorvdValk avatar ViktorvdValk commented on September 26, 2024 1

This was indeed a very, quick temporal solution, since it wasn't a priority back then.
But I'll now try to fix this issue in the itkTransformixFilter file in elastix.

from itkelastix.

thewtex avatar thewtex commented on September 26, 2024 1

The itk.elastix_registration_method function is automatically generated from the itk::ElastixRegistrationMethod class. Indexed input's and output's to that class become the position args. The Set* methods become the kwargs (also supporting snake_case). For SimpleElastix, it was a different, involved manual process.

from itkelastix.

ViktorvdValk avatar ViktorvdValk commented on September 26, 2024

How is the python itk.elastix_registration_method() defined (how does it know which functions to call in order)? Is this automatically done with swig or is it defined as a c++ method like in SimpleElastix?
In the swig case: What are the ruled for this automatic swig python wrapping?
And in the SimpleElastix case: In which file is it defined? (I haven't found it so far)

from itkelastix.

ViktorvdValk avatar ViktorvdValk commented on September 26, 2024

And how are the internal function calls and the output of the function generated?

from itkelastix.

thewtex avatar thewtex commented on September 26, 2024

E.g. https://github.com/InsightSoftwareConsortium/ITK/blob/9ff84420e55d2f86984f40f14861bddf0812b82b/Wrapping/Generators/Python/PyBase/pyBase.i#L280-L354

from itkelastix.

ViktorvdValk avatar ViktorvdValk commented on September 26, 2024

@thewtex Where did you get this error? I can't reproduce it locally (windows and mac) nor on the CI

from itkelastix.

thewtex avatar thewtex commented on September 26, 2024

@ViktorvdValk to reproduce the error, uncomment:

# Fails per:
# https://github.com/InsightSoftwareConsortium/ITKElastix/issues/108j
# jacobian = itk.transformix_jacobian(moving, parameters, log_to_console=True)

from itkelastix.

ViktorvdValk avatar ViktorvdValk commented on September 26, 2024

Yes, but that doesn't give me the error, not on the CI, nor on windows or mac. See https://github.com/InsightSoftwareConsortium/ITKElastix/compare/transformix_jacobian

from itkelastix.

thewtex avatar thewtex commented on September 26, 2024

@ViktorvdValk interesting.. could a PR please be created to enable the test in CI, please?

from itkelastix.

thewtex avatar thewtex commented on September 26, 2024

@N-Dekker has this been addressed with elastix 0.16.0?

from itkelastix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.