Comments (9)
N-Dekker
commented on June 24, 2024
2
@NHPatterson Thanks for reporting this issue, Heath. Stefan (@stefanklein), Viktor (@ViktorvdValk) and I just discussed the issue. It appears that elastix::SimilarityTransformElastix should override CreateTransformParametersMap, in order to fix this issue. I will try to fix it soon!
from itkelastix.
ViktorvdValk
commented on June 24, 2024
1
The same counts for AffineDTITransform, see issue 366 on elastix repo
from itkelastix.
ViktorvdValk
commented on June 24, 2024
1
@N-Dekker I checked all the transforms in python and the same happens for:
- AffineLogStackTransform
- AffineLogTransformElastix
- EulerStackTransform
AdvancedAffineTransformElastix is just the AffineTransform which does return the CenterOfRotationPoint
from itkelastix.
N-Dekker
commented on June 24, 2024
1
@NHPatterson Hi Heath! I'm closing the issue now, as I think we got it fixed 😃 By pull request SuperElastix/elastix#379 "Add missing parameters to transform parameter maps", which is just merged onto the https://github.com/SuperElastix/elastix develop branch. If you have the time, please check it out! And of course, if you think the issue is not entirely fixed, please feel free to reopen the issue, or submit another one. Thanks again!
from itkelastix.
N-Dekker
commented on June 24, 2024
The same counts for AffineDTITransform, see issue 366 on elastix repo
Thanks @ViktorvdValk I just assigned issue SuperElastix/elastix#366 to myself 😄
from itkelastix.
N-Dekker
commented on June 24, 2024
@stefanklein @ViktorvdValk I think this issue should be fixed by SuperElastix/elastix#379 But then, what about the following three elastix transform types?
AdvancedAffineTransformElastixAffineLogTransformElastixEulerStackTransform
Are these three fine, or should they get a similar fix? Is it possible to check that in Python?
from itkelastix.
stefanklein
commented on June 24, 2024
Hi Niels,
Potentially these could suffer from the same problem. You could see it by verifying if they have a CreateTransformParameterMap function, and compare that implementation to the WriteTransformParameterFile code.
Potentially, any transform that saves some transform specific settings (not just CenterOfRotationPoint) to a TransformParameter file (in the function WriteTransformParameterFile) could suffer from this problem when the CreateTransformParameterMap function is not in sync.
Best, Stefan
From: Niels Dekker <[email protected]>
Sent: Tuesday, December 22, 2020 10:06 PM
To: InsightSoftwareConsortium/ITKElastix <[email protected]>
Cc: S. Klein <[email protected]>; Mention <[email protected]>
Subject: Re: [InsightSoftwareConsortium/ITKElastix] 2D similarity transform parameter map doesn't keep "CenterOfRotationPoint" parameter (#93)
@stefanklein<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fstefanklein&data=04%7C01%7Cs.klein%40erasmusmc.nl%7C4f0fcd00e2b0431124d408d8a6bd6b9c%7C526638ba6af34b0fa532a1a511f4ac80%7C0%7C0%7C637442679778961169%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Gl3Kxwt%2B%2B8XHyG1l85qISSFssbZPQXDeFpi%2FE1uTD5o%3D&reserved=0> @ViktorvdValk<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FViktorvdValk&data=04%7C01%7Cs.klein%40erasmusmc.nl%7C4f0fcd00e2b0431124d408d8a6bd6b9c%7C526638ba6af34b0fa532a1a511f4ac80%7C0%7C0%7C637442679778961169%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=E6YGftrekd2FpoGfIUzXmdt8eo5x6OYeD1tQyy3fz94%3D&reserved=0> I think this issue should be fixed by SuperElastix/elastix#379<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSuperElastix%2Felastix%2Fpull%2F379&data=04%7C01%7Cs.klein%40erasmusmc.nl%7C4f0fcd00e2b0431124d408d8a6bd6b9c%7C526638ba6af34b0fa532a1a511f4ac80%7C0%7C0%7C637442679778971163%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=RMns42UBWwnz3yhQk%2BvBopLz5R3dHI92aO2TX0FeChY%3D&reserved=0> But then, what about the following three elastix transform types?
* AdvancedAffineTransformElastix
* AffineLogTransformElastix
* EulerStackTransform
Are these three fine, or should they get a similar fix? Is it possible to check that in Python?
-
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FInsightSoftwareConsortium%2FITKElastix%2Fissues%2F93%23issuecomment-749775974&data=04%7C01%7Cs.klein%40erasmusmc.nl%7C4f0fcd00e2b0431124d408d8a6bd6b9c%7C526638ba6af34b0fa532a1a511f4ac80%7C0%7C0%7C637442679778971163%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=J6API7gN0t1FWYhU8G%2FkHPfM1qXWQV2x%2Fayb7CMIP00%3D&reserved=0>, or unsubscribe<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAF2LNNLS7HJBJRPEOMQVV3SWEC4NANCNFSM4U5JUIPA&data=04%7C01%7Cs.klein%40erasmusmc.nl%7C4f0fcd00e2b0431124d408d8a6bd6b9c%7C526638ba6af34b0fa532a1a511f4ac80%7C0%7C0%7C637442679778981162%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=hVhi1a3HljF3pUPT1%2Fw4%2B99QWAVYye28iY%2FvjYORV5I%3D&reserved=0>.
from itkelastix.
N-Dekker
commented on June 24, 2024
@ViktorvdValk Do you mean that those three transforms (AffineLogStackTransform, AffineLogTransformElastix, EulerStackTransform) also need to be fixed (the same like Similarity and AffineDTI)?
from itkelastix.
ViktorvdValk
commented on June 24, 2024
Yes, to be certain, you check this with the verification Stefan mentioned, but if I print the output of one of these transforms, it doesn't contain the 'CenterOfRotationPoint' parameter.
from itkelastix.
Related Issues (20)
- Latest ITKElastix crashes HOT 6
- How to minimise non-rigid distortion when using groupwise registration HOT 3
- pip install itk-elastix does not work HOT 3
- register these two dicom file HOT 1
- Extraction deformation field after 3D registration.
- Error loading initial transform and applying mask
- Error when multiprocessing coregistration HOT 1
- Groupwise registration of 4D objects and registration with mask
- Applying series of registrations to moving image label map HOT 4
- Reset random seed for deterministic registration HOT 7
- Data format differs from the example HOT 1
- Data format differs from the example HOT 1
- itk.ParameterObject -> seg fault in fresh env HOT 5
- Issue with image format HOT 1
- Elastix Model Zoo site cannot be opened HOT 1
- Inverse transform HOT 11
- ErodeMask and dilating mask
- GroupwiseRegistration notebook: ERROR: the direction cosines matrix of the fixed image is invalid! HOT 2
- Transform coordinates from moving images space to fixed images space HOT 1
- Error of multi-metric and multi-channel image registration HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from itkelastix.