Comments (7)
hey Stefan,
thanks for reporting! This should only happen when new people join the team, or if something goes wrong when fetching the user list upon the first connection, but it should be an easy fix. The first is basically #3 . The latter, I've never seen in practice.
Can you verify if this issue appears only with newly joined people?
Thanks
from irc-slack.
I can't reproduce locally, but I had a feeling about what it could be. @chex3 mind to test it with this patch? https://github.com/insomniacslk/irc-slack/compare/nick_join_part
from irc-slack.
I could reproduce the error. This happens on larger Slack channels/teams. Slack started truncating the list of members as of December 2017, https://api.slack.com/changelog/2017-10-members-array-truncating . Currently the list is capped at 500 members, so only 500 people per channel will be resolved from ID to name.
The solution is to use conversation.members
instead. I will work on a fix in the next days
from irc-slack.
I fixed the issue on my side but this also needs fixing in the underlying slack library as pointed out in the above PR
from irc-slack.
I also need to port that code for groups, and refactor and clean it up
from irc-slack.
done in 57df949
from irc-slack.
hi @insomniacslk , i noticed this issue still popping up, but in a somewhat different behaviour: I have a Slack environment where i'm part of 40 channels. And for the last 10 channels or so, it starts showing all the usernames as these U...
nicknames.
However, when they type a message, i do see their proper handle.
Also, in our mandatory general channel, all users show up correctly, so it is able to fetch larger numbers of users (there's 450 users on that).
Example of such a channel:
19:17:25 [Users #unique_constraints]
19:17:25 [ pdellaert] [ U09CVRLAJ] [ U0G8NFSUT] [ U22A0V50S] [ UE39T0HQQ]
19:17:25 [ U02TFCBT4] [ U0A2TAARJ] [ U0KNMA9J8] [ U2ASEM5FD]
19:17:25 [ U03CE7MSM] [ U0CUBPBBM] [ U0TGZQ1E2] [ U6Y42SF71]
19:17:25 -!- Irssi: #unique_constraints: Total of 13 nicks [0 ops, 0 halfops, 0 voices, 13 normal]
20:32:49 [Users #unique_constraints]
20:32:49 [ pdellaert] [ U09CVRLAJ] [ U0G8NFSUT] [ U22A0V50S] [ UE39T0HQQ]
20:32:49 [ U02TFCBT4] [ U0A2TAARJ] [ U0KNMA9J8] [ U2ASEM5FD]
20:32:49 [ U03CE7MSM] [ U0CUBPBBM] [ U0TGZQ1E2] [ U6Y42SF71]
(Initial is join, second is a /n
in irssi)
from irc-slack.
Related Issues (20)
- Reply with RPL_NOTOPIC if no topic is set
- Use slacks 'away' flag when loading slack users HOT 4
- My own messages are shown twice HOT 8
- Getting Connection Timeout Trying to Setup new Connection HOT 9
- Handle certain JOIN failures
- Handle user change event and show nick change if relevant
- App on slack.efi.re throws 502 error HOT 3
- Add feature matrix on README
- Fix `cannot create nick "" for channel "+chan-12345"`
- Messages posted to threads show up in 1-on-1 channels HOT 8
- Clean up resources after disconnecting from a team
- Support threads to self
- Send IM thread to a thread channel
- Support sending messages in thread and multiparty IMs HOT 1
- Failed to fetch users by their IDs: internal_error HOT 2
- irc-slack + znc constantly adding new channels HOT 1
- irc-slack 'reactions' being sent to the wrong channels HOT 1
- Only one private channel working. Other channels sent to <unknown-channel> HOT 1
- Members of private channels and threads not shown HOT 1
- cannot connect anymore since 2023-09-18 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from irc-slack.