Menu not working with react-native-router-flux 4 about react-native-popup-menu HOT 11 CLOSED

thank you - I can reproduce the bug now. We will need some time to fix it properly however here is small workaround - wrap your router definition so that it does not rerender like

  <Provider store={store}>
    <MenuContext style={{ flex: 1 }}>
      <StaticRenderer>
        <RouterComponent />
      </StaticRenderer>
    </MenuContext>
  </Provider>

example implementation of StaticRenderer

class StaticRenderer extends Component {
  shouldComponentUpdate() {
    return false;
  }
  render() {
    return React.Children.only(this.props.children)
  }
}

from react-native-popup-menu.

as far I have seen the bug - it has side effects (remounting of menu) if the router is not shielded from MenuContext. Unless you have something else "above" the router that might change the router definition somehow - it is safe to wrap router.

Right now we are working on refactoring of our internals so that such workarounds are not needed but we need more time for it.

from react-native-popup-menu.

@sodik82 I'm sorry for the late response but I can confirm it indeed works without the workaround for me. Cheers 👍

from react-native-popup-menu.

Thank you. I have tried simplified example and seems to work:

  <Provider store={store}>
    <MenuContext style={{ flex: 1 }}>
      <Testing />
    </MenuContext>
  </Provider>

Maybe if you can share with us details about your used navigation (which library, sample setup)? Or maybe if you can confirm first if it works without the Router?

from react-native-popup-menu.

For navigation I'm using [email protected] with the following setup on the Router:

const RouterComponent = () => (
  <Router>
    <Scene hideNavBar>
      <Stack key="auth" initial>
        <Scene
          key="testing"
          component={Testing}
          title="Testing"
          initial
        />
      {/*... */} 
      </Stack>
    {/*... */} 
    </Scene>
  </Router>
);

EDIT: Ok, I tried it without the Router and it's working. Any idea as to why?

from react-native-popup-menu.

I'm fairly new to React Native, so forgive my ignorance when I ask you:
Will wrapping the router as suggested have any other (side-)effects?

Anyways, thanks for the fast response and fix! 👍

from react-native-popup-menu.

@Hugainz - new version 0.8.2 should work without any workarounds. can you confirm it?

from react-native-popup-menu.

it's not working. I have the new version 0.8.3

from react-native-popup-menu.

can you provide us more details? does it work with workaround? what error/unexpected behaviour do you get? more details about your setup?

from react-native-popup-menu.

I will give a try again, thanks for the feedback.

from react-native-popup-menu.

@mohamed-alashry - thanks. maybe it is unrelated problem (maybe #41 ). but if you have any more information about your problem we can resolve it.

from react-native-popup-menu.