Comments (5)
I did some more digging, and it looks like the "cmk uninstall" command will only work on one node, since it tries to delete the webhook and that can only succeed on one node (since on the other nodes it'll already be deleted). When that fails on the other nodes it aborts the uninstall leaving the node in a partially-installed state.
from cpu-manager-for-kubernetes.
@cbf123 thanks for raising this issue. Are you using the cmk-uninstall pod or the cmk-uninstall daemonset?
from cpu-manager-for-kubernetes.
In the uninstall
module all "delete something" functions do sys.exit(1)
whenever any exception is raised. I think it would be better to display warnings in the logs and continue trying to remove all resources in the best effort mode without exiting early.
from cpu-manager-for-kubernetes.
I created a draft pull request linked above, which changes uninstall module behaviour to described. Feel free to give it a try and report your feedback.
I marked it as a "Draft" as most of the uninstall related tests fail now, I'll be happy to fix them once we agree that this is the right way to perform the uninstall process.
from cpu-manager-for-kubernetes.
lmdaly: I tried both options. With the cmk-uninstall pod you need to run it on each node manually, and it'll only successfully run on the first node. With the daemonset the first pod to run will be successful, and the other pods fail and keep restarting.
przemeklal: That's one way to do it, and I think it makes sense to clean up as much as we can on an uninstall. I took an alternate approach as attached which is a bit more narrow but I think I like yours better.
diff.txt
from cpu-manager-for-kubernetes.
Related Issues (20)
- Only one node picked up by cluster-init which also fails with Forbidden Error HOT 1
- Cannot build CMK Docker image
- Issue about using hyper-thread in exclusive mode HOT 4
- Pin CPU for Pod on K8s
- INTERNAL ERROR: cannot create temporary directory! HOT 2
- can not run on the ARM v8 CPUs
- operator.md incorrectly states to set --insecure to false to revert back to regular TLS
- CMK Helm Chart Guidelines HOT 1
- CMK Configmap is hard to manage HOT 13
- CMK on Cluster Multi Node environment HOT 5
- CMK Isolation on different NUMA nodes HOT 6
- CMK crashes on Intel® Xeon® Processor E5-2690 HOT 1
- Error getting cmk-config-<node-name> Configmap HOT 2
- cmk-cluster-init-pod failed with CreateContainerConfigError HOT 3
- CMK reconfiguration function errors
- keyerror observed while running isolate command HOT 3
- Processes in shared pool not actually sharing the cores
- CMK resources are not showing after upgrading k8s
- Different pools for different containers
- CPU isolation from host daemons without isolcpus
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cpu-manager-for-kubernetes.