Giter VIP home page Giter VIP logo

Comments (4)

grgustaf avatar grgustaf commented on August 25, 2024

Yeah, this is a new problem that comes from an update in Zephyr tree. I don't think us tracking the tips of JerryScript and Zephyr randomly is very smart. In my "overlay" patch recently I added the ability for us to choose a particular commit for each to work with, and then we could advance that as we ensure compatibility to make our build more stable.

@jimmy-huang, can you please add your fix here too?

from zephyr.js.

kenchris avatar kenchris commented on August 25, 2024

That is how Chromium works. It has a DEPS file and the tool, fetching with these known-to-work hashes

Example: https://chromium.googlesource.com/chromium/src/+/lkgr/DEPS

(not saying that we have to duplicate what they do - we can make something much simpler :-))

from zephyr.js.

grgustaf avatar grgustaf commented on August 25, 2024

Yeah my version looks like this in repos.txt:
jerryscript https://github.com/Samsung/jerryscript.git master

So master can be replaced with ba55f154 and such.

Actually, this is already in the tree, not part of the pending overlay patch.

I think we'll just directly commit updates to those commit ids rather than submit PRs, to avoid confusion as to what code we're building against. We could even have jsrunner verify that you're on the right commits in your deps to avoid issues due to mismatches.

from zephyr.js.

jimmy-huang avatar jimmy-huang commented on August 25, 2024

Submitted pr #32

from zephyr.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.