Giter VIP home page Giter VIP logo

Comments (1)

nathankleyn avatar nathankleyn commented on June 2, 2024

I think this one we probably shouldn't do for two reasons.

If we have a file hello/world.go in a repo foo, you'll end up with a URL like this:

"/repo/foo/hello/world.go" // or,
"/repo/foo/hello/world.go?reference=sometag"

Which kind of trashes the REST approach to URLs of having the resource be a single segment of the path β€”Β and I believe quite a few web frameworks won't let you match on parts of URLs with unlimited slashes in it like this so could be boxing us into the frameworks that do allow this.

The other reason is safety: If this file path comes from anywhere dynamic, you'll need to URL escape it. If it's in the path, it isn't easy to escape everything except the slashes β€” whereas if it's in the query string, you can just URL escape the entire value and it'll be safe.

from gitkv.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.