Comments (1)
I think this one we probably shouldn't do for two reasons.
If we have a file hello/world.go
in a repo foo
, you'll end up with a URL like this:
"/repo/foo/hello/world.go" // or,
"/repo/foo/hello/world.go?reference=sometag"
Which kind of trashes the REST approach to URLs of having the resource be a single segment of the path βΒ and I believe quite a few web frameworks won't let you match on parts of URLs with unlimited slashes in it like this so could be boxing us into the frameworks that do allow this.
The other reason is safety: If this file path comes from anywhere dynamic, you'll need to URL escape it. If it's in the path, it isn't easy to escape everything except the slashes β whereas if it's in the query string, you can just URL escape the entire value and it'll be safe.
from gitkv.
Related Issues (16)
- Skeleton of project and README
- Selection of repos based on a predefined list HOT 1
- If the target directory exists, fetch/pull instead of clone HOT 1
- Add CI build
- Fix Travis builds for osx
- Write tests for POC code HOT 1
- Include content type header for returned file
- Server tests timeout if valid URL used
- Return proper HTTP errors HOT 4
- Build failing HOT 1
- Update readme usage docs HOT 1
- Package as Docker HOT 4
- Return directory listings as JSON HOT 1
- Docker image that offers git repos as volumes HOT 1
- Gitkv 0.1.2 panics on start HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitkv.