Giter VIP home page Giter VIP logo

Comments (5)

kazupon avatar kazupon commented on July 28, 2024

Thank you for your feeback!

As the reason provide te, simply because we want to detect if a message exists for the current local, or for the locale specified in the parameters.

The t function has a fallback cost.
To avoid that cost, and to avoid missing translations, this API is provided.

from vue-i18n.

valoricDe avatar valoricDe commented on July 28, 2024

I think we agree that there are different UseCases.
In our case by using te we want to know if a translation exists and if there is a translation fallback. We are fine with having the additional cost (as it is inevitable in our case). If the key not exists we try another key.

Our own fallback translationExists function looks like this now:

function translateOrEmpty(i18n, key) {
  const translation = i18n.t(key);
  if (translation === key) return '';
  return translation;
}

But it raises an error for missing transations in our test cases.

We could also create our own fallback schema for te but it seems weird recreating the logik of t.

What are your thoughts on this?

from vue-i18n.

BobbieGoede avatar BobbieGoede commented on July 28, 2024

Expected behavior
I think it is problematic that the behaviour of t and te is different.

Would something like this be what you're looking for?

function hasTranslationOrFallback(i18n, key) {
  return i18n.te(key) || i18n.te(key, i18n.fallbackLocale.value)
}

from vue-i18n.

valoricDe avatar valoricDe commented on July 28, 2024

As far as I know you can define multiple fallback levels (de-DE-BR -> de-AT -> de -> en). So it would need to be iterative.
Edit: https://vue-i18n.intlify.dev/guide/essentials/fallback.html#explicit-fallback-with-decision-maps

from vue-i18n.

valoricDe avatar valoricDe commented on July 28, 2024

Thinking about it. I actually don't care about the te function. Because in my eyes it is more efficient to directly try to translate and check if I got the key returned than first checking if it exists and then translate it (-> 2x resolving).

So I silenced the warnings I get in the jest tests. If you agree we can close this ticket

from vue-i18n.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.