Giter VIP home page Giter VIP logo

Comments (4)

prncc avatar prncc commented on June 11, 2024

Hi @hannadrehman,

The plugin does a lot of work on the initial render because it has to parse and compile the theme.scss file, extract the variables, inject them into antd's theme file to generate an SCSS theme and make it available to the locally running app. The good news is that this should only happen again when you change the theme file, so it should not affect future re-compilations (thanks to registering the theme with Webpack).

By the way, did you run the profiling with the plugin removed -- I'd be curious to see those results! :)

from antd-scss-theme-plugin.

prncc avatar prncc commented on June 11, 2024

I forgot to mention. This block:

AntdScssThemePlugin.themify({
              loader: 'fast-sass-loader',

won't do anything; the plugin only modifies less-loader and sass-loader.

from antd-scss-theme-plugin.

hannadrehman avatar hannadrehman commented on June 11, 2024

@prncc thanks for replying. when i started the project i was using material ui as ui component lib,
scss build at that time was fast like it took at max 1-2 seconds to finish the build. but then when i switched to antd and used this plugin it started slowing down..
if its slow for the first time its fine. but it generally keeps on taking around 4-5 seconds to finish the build. i will have to try my project without this plugin then i can compare the two. bdw what is the expected speed of build in all ideal conditions ?

from antd-scss-theme-plugin.

prncc avatar prncc commented on June 11, 2024

Not clear what the expected build time should be for your project, but if you do run some benchmarks with and without the plugin, I'd be curious to hear the results.

from antd-scss-theme-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.