Suspected License Violation about quickbooks-v3-dotnet-sdk HOT 9 CLOSED

HI @brockallen - We didn't mean to leave off the copyright and we will open up an issue with open source identity team to address it. Meanwhile, I have updated the files even the modified, added ones to include the Licensing from IdentityModel2 repo.

Thanks,
Nimisha

from quickbooks-v3-dotnet-sdk.

Thank you for following up on this.

I think moving forward we want to understand what in IdentityModel was blocking you in the first place. Did you open any issues in our repo asking for enhancements? I would think that's the best approach: 1) let us know what might need changing to support your scenario, and 2) then you should be referencing our library via the nuget package rather than copying the source code.

If that was done originally, then this issue could have been avoided.

from quickbooks-v3-dotnet-sdk.

Hi @brockallen,
Intuit mistakenly published this library without the copyright notice. This was an oversight on our part, and the result of a misunderstanding of the open source licensing process by our team. We fully support the open source community and regret our error.

The issue has been corrected here: 506b872#diff-68341b3e1ed04a5b6a86868254db097d

regards
Jarred Keneally
Director, Intuit Developer Relations

from quickbooks-v3-dotnet-sdk.

Hi @brockallen - I will setup a call with you in a week's time to go over the changes we did for the Intuit's implementation as it was limited to just server side Oauth2 support and having some additional params like realm/company id support. Hopefully you could help us with the questions then and suggest what best we can do to handle those using your binaries instead. Thanks for the guidelines.

from quickbooks-v3-dotnet-sdk.

Yes, I was able to get all my questions answered. However, I am currently on maternity leave for 3 weeks. Once I return back, I will give you an update on the release for the Oauth2 lib using the binaries. Thanks for all the help.

from quickbooks-v3-dotnet-sdk.

Were you able to finally get all your questions/features covered with IdentityModel? If so, then were you able to get the code to reuse IdentityModel as a NuGet, which is preferable to copying the code in?

from quickbooks-v3-dotnet-sdk.

Ok, thanks for the update.

And congratulations!

from quickbooks-v3-dotnet-sdk.

Hi @brockallen,

Just wanted to update this thread too.
We discussed with @leastprivilege here- IdentityModel/IdentityModel#164 (comment)
and with Scott too.

Due to limitation of Dotnet extensions for adding new properties and lack of support for domain specific properties, we will not be making any code changes to the Oauth2PlatformClient as this will break client apps using our SDK.
Also, the “type” of response for different endpoints would be different – instead of Intuit.Ipp.Oauth2PlatformClient unless we explicitly hardcode each and every response property value. Not a goof solution for us to use the binaries then. Again this would be a breaking change.

We will consider the use of binaries once we migrate our SDK to support .Net Core.
Thanks,
Nimisha

from quickbooks-v3-dotnet-sdk.

Fair enough. Thanks for the updates to restore the copyrights and honor the license.

from quickbooks-v3-dotnet-sdk.