Comments (3)
I think this is a great improvement, as we've had some folks that really want to change the color of the badges and couldn't in the existing implementation
from invenio-formatter.
Thanks, Tom. I guess embedding the colour in the URL might not be desierable (although perhaps systems embedding the badge would benefit from this?)
But maybe it would be better to have a config option like RDM_BADGE_COLOR_MAP = { "doi" : "#fcb425" }
?
from invenio-formatter.
I think embedding the color in the badge makes sense from the perspective of users embedding the badges in their own personal web site. Here is an example where someone really wanted specific colors for their badges https://github.com/caltechlibrary/boffo#readme
I think a config option is good too, since RDM admins will want to theme the default badge color across the site. So I'd be in favor of doing both.
from invenio-formatter.
Related Issues (20)
- docs: update structure HOT 1
- tests: addition of test_example_app.py
- release: beta version checklist HOT 3
- installation: CairoSVG 2.0 drops Python 2 support
- tests: simplify doctest execution
- views: meta_highwire rendering fails for publication dates before 1900-01-01
- docs: example application not rendered on readthedocs
- views: badges should contain "no-cache"-ing headers
- travis: remove pypy from test matrix
- tests: build failure
- travis: fix build failure HOT 1
- release 1.0.3
- global: migrate templates/assets to Semantic-UI
- global: migrate templates/assets to Semantic-UI
- semantic-ui badges do not display correctly
- global: release v1.1.0
- global: migration to github-actions from travis
- Doi badge svg is not created
- Installation instructions reference non-existent option "badges"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from invenio-formatter.