Giter VIP home page Giter VIP logo

Comments (3)

tmorrell avatar tmorrell commented on July 21, 2024

I think this is a great improvement, as we've had some folks that really want to change the color of the badges and couldn't in the existing implementation

from invenio-formatter.

dfdan avatar dfdan commented on July 21, 2024

Thanks, Tom. I guess embedding the colour in the URL might not be desierable (although perhaps systems embedding the badge would benefit from this?)

But maybe it would be better to have a config option like RDM_BADGE_COLOR_MAP = { "doi" : "#fcb425" } ?

from invenio-formatter.

tmorrell avatar tmorrell commented on July 21, 2024

I think embedding the color in the badge makes sense from the perspective of users embedding the badges in their own personal web site. Here is an example where someone really wanted specific colors for their badges https://github.com/caltechlibrary/boffo#readme

I think a config option is good too, since RDM admins will want to theme the default badge color across the site. So I'd be in favor of doing both.

from invenio-formatter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.