Comments (6)
I'll opt for following signature:
publish($body!, \%headers?, *@params)
which will allow to call it like this:
->publish($body, { header => 'value' }, routing_key => 'something',
mandatory => 1, immediate => 0);
->publish($body, routing_key => 'something');
->publish($body, { header => 'value' });
->publish($body);
With following rules:
- if $body is hashref default content_type is set to application/json and $body is encoded to JSON string, otherwise it will be passed as-is,
- if second argument is hashref it will be merged with default headers, replacing any pre-existing values, if it's defined but not a hashref it will be treated as below,
- any other (slurpy) arguments will be treated as key/value pairs and merged with AMQP publish method default parameters
What do you think?
from mojo-rabbitmq-client.
I'm fine with that!
Do you want a PR with that or would you prefer to do it yourself?
from mojo-rabbitmq-client.
If you can, please write a PR - I don't have much spare time lately
from mojo-rabbitmq-client.
@tyldum Just make it flexible.
from mojo-rabbitmq-client.
In a5e148f I've changed publisher code to use ?routing_key=
query parameter instead of ?queue=
from mojo-rabbitmq-client.
Resolved in 5a7cf91
from mojo-rabbitmq-client.
Related Issues (20)
- Early success event from ->publish HOT 2
- Implement blocking publisher API HOT 3
- Update documentation
- Proper tests for all Promise methods
- Circular includes
- Making Mojo::RabbitMQ::Client::Consumer use promises HOT 1
- Mojo::RabbitMQ::Client gets destroyed too soon using morbo HOT 1
- Unable to use consumer API
- Channel is closed in forked childs HOT 11
- Publisher documentation's examples are hard to parse HOT 1
- repo and tarballs include non-free file without notification HOT 1
- 'weaken $self' leads to undefined errors
- Body larger than frame_max not split into multiple frames
- RMQ message not sent intermittently
- Client disconnect doc example uses 'close' HOT 1
- publish with mandatory but without routing_key leads to uninitialized warning
- is_open incorrect after disconnect event
- hard to debug connection failure
- How to reject a message and I'd like to contribute
- Disabling TLS certificate validation doesn't work
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mojo-rabbitmq-client.