Giter VIP home page Giter VIP logo

Comments (6)

SPodjasek avatar SPodjasek commented on June 10, 2024

I'll opt for following signature:

publish($body!, \%headers?, *@params)

which will allow to call it like this:

->publish($body, { header => 'value' }, routing_key => 'something', 
                                        mandatory => 1, immediate => 0);
->publish($body, routing_key => 'something');
->publish($body, { header => 'value' });
->publish($body);

With following rules:

  • if $body is hashref default content_type is set to application/json and $body is encoded to JSON string, otherwise it will be passed as-is,
  • if second argument is hashref it will be merged with default headers, replacing any pre-existing values, if it's defined but not a hashref it will be treated as below,
  • any other (slurpy) arguments will be treated as key/value pairs and merged with AMQP publish method default parameters

What do you think?

from mojo-rabbitmq-client.

tyldum avatar tyldum commented on June 10, 2024

I'm fine with that!
Do you want a PR with that or would you prefer to do it yourself?

from mojo-rabbitmq-client.

SPodjasek avatar SPodjasek commented on June 10, 2024

If you can, please write a PR - I don't have much spare time lately

from mojo-rabbitmq-client.

kraih avatar kraih commented on June 10, 2024

@tyldum Just make it flexible.

from mojo-rabbitmq-client.

SPodjasek avatar SPodjasek commented on June 10, 2024

In a5e148f I've changed publisher code to use ?routing_key= query parameter instead of ?queue=

from mojo-rabbitmq-client.

SPodjasek avatar SPodjasek commented on June 10, 2024

Resolved in 5a7cf91

from mojo-rabbitmq-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.