Giter VIP home page Giter VIP logo

Comments (4)

AlCalzone avatar AlCalzone commented on July 29, 2024

I need to rethink the unit tests. They don't rely on a real js-controller so the directory is not expected to actually exist or even point to a real controller. The constant merely exists so adapters that import tools.js can use that in unit tests - with a mocked tools.js of course.

Mocking and then copying the original behavior in mocks doesn't make sense.

from testing.

Garfonso avatar Garfonso commented on July 29, 2024

In this case it tries to load the letsencrypt.js file from js-controler. So that should be mocked, too?

from testing.

AlCalzone avatar AlCalzone commented on July 29, 2024

Jup, but like I wrote, this is becoming pointless, so probably just comment out the unit test in travis/Github Actions

from testing.

Garfonso avatar Garfonso commented on July 29, 2024

I re-read the documentation and tried a bit more. The issue of loading letsencrypt works, if I change the default unit.js to something like this, i.e. add the mock of letsencrypt. Of course that will fail, if the adapter tries to use something from letsencrypt. Hm... But for the default config it works. ;-)

from testing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.