Comments (4)
I need to rethink the unit tests. They don't rely on a real js-controller so the directory is not expected to actually exist or even point to a real controller. The constant merely exists so adapters that import tools.js can use that in unit tests - with a mocked tools.js of course.
Mocking and then copying the original behavior in mocks doesn't make sense.
from testing.
In this case it tries to load the letsencrypt.js file from js-controler. So that should be mocked, too?
from testing.
Jup, but like I wrote, this is becoming pointless, so probably just comment out the unit test in travis/Github Actions
from testing.
I re-read the documentation and tried a bit more. The issue of loading letsencrypt works, if I change the default unit.js to something like this, i.e. add the mock of letsencrypt. Of course that will fail, if the adapter tries to use something from letsencrypt. Hm... But for the default config it works. ;-)
from testing.
Related Issues (20)
- DB needs to be up and running before installing the adapter instance
- Workflow fails when installing VIS (dependency) HOT 3
- Feature Request "setup of native objects for adapter initialization" (#218 proposal not working anymore) HOT 3
- Verify that no dependency "npm" is in the adapter
- Allow schedule adapters to quit immediately (don't check for .alive) HOT 10
- Upload at least www file sbefore start testing HOT 1
- Local run of integration tests fails instant with "js-controller running" error HOT 5
- Integration tests: residual objects in object database HOT 2
- Make loglevel configurable
- Add option to start instance only in beforeAll and stop it in afterAll HOT 1
- Support of suite.skip HOT 3
- Best way to wait for adapter stop? HOT 5
- no reply to sendTo received since update to 4.x HOT 1
- Unexpected Token Error for "Test and Release" Action HOT 2
- Clear tmp directory when switching controller versions
- Test io-pack against Schema HOT 1
- test-and-release fails for wwwOnly adapters HOT 2
- test-and-release: package check should check for adapter dependencies
- Test jsonConfig against schema HOT 1
- Add ts support to testings HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from testing.