Giter VIP home page Giter VIP logo

Comments (7)

rwaskiewicz avatar rwaskiewicz commented on May 27, 2024 1

Thanks! I'll get this ingested for someone to take a look

from stencil.

alicewriteswrongs avatar alicewriteswrongs commented on May 27, 2024 1

Hey @gregorypratt I just opened a PR with a fix that I believe addresses the issue - if you get a minute would you mind trying it out and confirming that it fixes it for you?

You can install a dev build with the fix like so:

npm install @stencil/[email protected]

from stencil.

rwaskiewicz avatar rwaskiewicz commented on May 27, 2024

Hey @gregorypratt 👋

Thanks for the detailed bug report! I do see the warning appearing here locally. Before we move forward here, is there anything else that we should know about in the reproduction? Specifically, is there anything broken here in terms of functionality (other than seeing the warning from vite)?

from stencil.

gregorypratt avatar gregorypratt commented on May 27, 2024

No I don't believe there is anything broken in the browser, and Vite is not used to build the dist of the component. It also doesn't look like there is an issue building storybook. However it of course makes it difficult if there are any other problems that are output to the console.

FWIW I have narrowed it down to the latest release specifically 👍

from stencil.

gregorypratt avatar gregorypratt commented on May 27, 2024

@alicewriteswrongs boom, looks good to me!

Super quick turn around thank you 🙇‍♂️

from stencil.

alicewriteswrongs avatar alicewriteswrongs commented on May 27, 2024

Excellent — thanks for trying it out! I'll get that merged today and the fix will be in the next release of Stencil - we'll ping here when that comes out

from stencil.

rwaskiewicz avatar rwaskiewicz commented on May 27, 2024

The fix for this issue has been released as a part of today's Stencil v4.12.4 release.

from stencil.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.