go-ipfs seams to rebroadcast the want list on a fixed interval. In JS, there is a

we don‘t use the constant but we do rebroadcast already: <a href="https://github.com/i

Why are we rebroadcasting? <a hr

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

rebroadcast want list (should we?) about js-ipfs-bitswap HOT 7 CLOSED

pgte commented on August 16, 2024

rebroadcast want list (should we?)

from js-ipfs-bitswap.

Comments (7)

dignifiedquire commented on August 16, 2024

we don‘t use the constant but we do rebroadcast already: https://github.com/ipfs/js-ipfs-bitswap/blob/master/src/want-manager/index.js#L118

from js-ipfs-bitswap.

pgte commented on August 16, 2024

Why are we rebroadcasting?

…

On 15 Dec 2017, 12:23 +0000, Friedel Ziegelmayer ***@***.***>, wrote: we don‘t use the constant but we do rebroadcast already: https://github.com/ipfs/js-ipfs-bitswap/blob/master/src/want-manager/index.js#L118 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

from js-ipfs-bitswap.

daviddias commented on August 16, 2024

@dignifiedquire @dgrisham can you follow up on this question?

from js-ipfs-bitswap.

dignifiedquire commented on August 16, 2024

Why are we rebroadcasting?

tldr, because go-ipfs does so.

I think the idea is to make sure things get eventually resolved if the initial sends don't yield any results. I suspect @whyrusleeping can shed more light on this.

from js-ipfs-bitswap.

dgrisham commented on August 16, 2024

It's not entirely obvious why we rebroadcast in go-ipfs from the source/comments (or the whitepaper, which mentions it as well). My guess is that it's to resolve any syncing issues that might build up over time with the incremental wantlist updates.

(Edit: Needless to say, this is something that could use better documentation.)

from js-ipfs-bitswap.

whyrusleeping commented on August 16, 2024

Yeah, the rebroadcasting isn't really needed anymore. It was from a less reliable time

…

On Thu, Jan 25, 2018, 6:41 PM David Grisham ***@***.***> wrote: It's not entirely obvious why we rebroadcast in go-ipfs from the source/comments (or the whitepaper, which mentions it as well). My guess is that it's to resolve any syncing issues that might build up over time with the incremental wantlist updates. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#160 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABL4HJMzT1utydjZVXXZN3kYc9d7OTxyks5tOTtTgaJpZM4RDOvC> .

from js-ipfs-bitswap.

daviddias commented on August 16, 2024

So the verdict is to remove this rebroadcast, correct?

from js-ipfs-bitswap.

Recommend Projects